Fix hang in OCSP Stapling test#10093
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Mar 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an indefinite hang in the ocsp_stapling external test by correcting how the IPv4/IPv6 selector flag is passed to nc and openssl commands (avoiding an empty, quoted argument that can break option parsing).
Changes:
- Pass
$V4V6_FLAGunquoted tonc -zwhen probing for free ports. - Pass
$V4V6_FLAGunquoted toopenssl s_clientto avoid an extra empty positional argument after-status. - Pass
$V4V6_FLAGunquoted toopenssl s_serverto avoid injecting an empty argument into the command line.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebastian-carpenter
approved these changes
Mar 27, 2026
Contributor
Author
|
Jenkins Retest this please |
douzzer
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ocsp_stapling test currently hangs indefinitely. Noticed by @sebastian-carpenter. This PR has minor syntax fixes to get the test working right
Testing
./configure --enable-ocsp --enable-ocspstapling && make && ./scripts/ocsp-stapling.testChecklist