Add Ed25519/Ed448 support to EVP layer by lealem47 · Pull Request #10135 · wolfSSL/wolfssl

lealem47 · 2026-04-06T16:10:39Z

Description

Adds Ed25519/Ed448 support to the EVP_PKEY layer (and testing)
Fix bug in d2iTryAltDhKey that caused RSAk, ECCk and DH to be the only usable algs in d2i_PUBKEY()/d2i_PrivateKey()
Fix NGINX regression with Ed25519k/Ed448k certs by mapping their OIDs in oid2nid(). The oid2nid() path previously wasn't hit for this builds as --enable-opensslall was only recently added to --enable-nginx

Fixes zd#21503 and zd#21514

Testing

Tested by customer and new unit tests

Checklist

added tests
updated/added doxygen
updated appropriate READMEs
Updated manual and documentation

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds missing Ed25519/Ed448 OID↔NID mappings to avoid regressions when Ed25519k/Ed448k certificates are processed via the oid2nid() path (notably impacting NGINX/OpenVPN scenarios).

Changes:

Map WC_NID_ED25519/WC_NID_ED448 to ED25519k/ED448k in nid2oid().
Map ED25519k/ED448k to WC_NID_ED25519/WC_NID_ED448 in oid2nid().
Add build-flag guards (HAVE_ED25519, HAVE_ED448) around the new switch cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

When wc_DhKeyDecode() rejected the input, d2iTryAltDhKey() returned 0 after freeing the DH object. d2i_evp_pkey_try() treats any value >= 0 as success, so a non-DH input would stop the probe chain at the DH step and never reach the Falcon, Dilithium, Ed25519, or Ed448 probes that follow. d2i_PUBKEY()/d2i_PrivateKey() consequently returned NULL for any key type past DH in the chain.

- Add WC_EVP_PKEY_ED25519 / WC_EVP_PKEY_ED448 type constants and matching EVP_PKEY_ED25519 / EVP_PKEY_ED448 OpenSSL aliases. - Extend WOLFSSL_EVP_PKEY with ed25519/ed448 fields and ownership bits, and free them in wolfSSL_EVP_PKEY_free(). - Add d2i probe functions that accept both SubjectPublicKeyInfo / PKCS#8 PrivateKeyInfo encodings and raw 32/57-byte key material, and hook them into the d2i_evp_pkey_try() chain. - Map the Ed25519/Ed448 signature OIDs in the relevant lookups and teach the PEM key-format dispatch and SSL_CTX_use_PrivateKey switch about the new types.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 13 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lealem47 · 2026-04-08T14:05:54Z

Jenkins retest this please.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-04-17T01:13:24Z

MemBrowse Memory Report

No memory changes detected for:

julek-wolfssl

Amazing @lealem47 !

JacobBarthelmeh

After some direct messages, the 2 new wolfSSL_* API's should be moved out of the wolfssl/wolfcrypt/*.h files for use in FIPS builds.

Add Ed25519/Ed448 cases to oid2nid() oidKeyType switch

97f1e44

lealem47 self-assigned this Apr 6, 2026

Copilot AI review requested due to automatic review settings April 6, 2026 16:10

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Copilot started reviewing on behalf of lealem47 April 6, 2026 16:18 View session

lealem47 added 3 commits April 6, 2026 12:28

Add testing for the new ED paths in EVP_PKEY layer

c01c434

Copilot AI review requested due to automatic review settings April 6, 2026 19:05

lealem47 force-pushed the nid_ED branch from 7b81e29 to c01c434 Compare April 6, 2026 19:05

lealem47 changed the title ~~Add Ed25519/Ed448 cases to oid2nid() oidKeyType switch~~ Add Ed25519/Ed448 support to EVP layer Apr 6, 2026

lealem47 requested a review from julek-wolfssl April 6, 2026 19:14

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Copilot started reviewing on behalf of lealem47 April 6, 2026 19:22 View session

Address Copilot feedback

8e26329

julek-wolfssl requested changes Apr 8, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 14, 2026 03:08

Copilot started reviewing on behalf of lealem47 April 14, 2026 03:11 View session

lealem47 requested a review from julek-wolfssl April 14, 2026 03:13

lealem47 assigned julek-wolfssl and wolfSSL-Bot and unassigned lealem47 Apr 14, 2026

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread wolfcrypt/src/evp_pk.c Outdated

Comment thread wolfcrypt/src/evp_pk.c Outdated

Address peer review comments

86c56de

lealem47 force-pushed the nid_ED branch from c8f6421 to 86c56de Compare April 14, 2026 03:33

julek-wolfssl requested changes Apr 14, 2026

View reviewed changes

Comment thread src/pk.c

Comment thread src/pk.c

Comment thread src/pk.c

julek-wolfssl assigned lealem47 and unassigned wolfSSL-Bot and julek-wolfssl Apr 14, 2026

lealem47 assigned julek-wolfssl and unassigned lealem47 Apr 17, 2026

Copilot started reviewing on behalf of lealem47 April 17, 2026 00:46 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

Comment thread wolfcrypt/src/evp_pk.c Outdated

Comment thread wolfcrypt/src/evp_pk.c Outdated

Comment thread tests/api/test_evp_pkey.c

julek-wolfssl requested changes Apr 17, 2026

View reviewed changes

Comment thread wolfcrypt/src/evp_pk.c Outdated

Comment thread wolfcrypt/src/evp_pk.c Outdated

julek-wolfssl assigned lealem47 and unassigned julek-wolfssl Apr 17, 2026

Add EVP_PKEY_new_raw_public_key and EVP_PKEY_new_raw_private_key

8b76230

lealem47 requested a review from julek-wolfssl April 20, 2026 20:39

lealem47 assigned wolfSSL-Bot and julek-wolfssl and unassigned lealem47 Apr 20, 2026

julek-wolfssl previously approved these changes Apr 21, 2026

View reviewed changes

julek-wolfssl removed their assignment Apr 21, 2026

SparkiDev reviewed Apr 22, 2026

View reviewed changes

Comment thread wolfssl/wolfcrypt/ed448.h Outdated

lealem47 requested a review from SparkiDev April 22, 2026 23:12

JacobBarthelmeh approved these changes Apr 23, 2026

View reviewed changes

JacobBarthelmeh requested changes Apr 23, 2026

View reviewed changes

JacobBarthelmeh assigned lealem47 and unassigned wolfSSL-Bot Apr 23, 2026

lealem47 dismissed julek-wolfssl’s stale review via baacd99 April 27, 2026 18:13

lealem47 requested a review from JacobBarthelmeh April 27, 2026 18:13

lealem47 assigned wolfSSL-Bot and unassigned lealem47 Apr 27, 2026

lealem47 force-pushed the nid_ED branch from baacd99 to df138cc Compare April 27, 2026 19:33

Move new wolfSSL_ED* API's to openssl/ed*.h headers

5da71f4

lealem47 force-pushed the nid_ED branch from df138cc to 5da71f4 Compare April 28, 2026 14:22

JacobBarthelmeh approved these changes Apr 30, 2026

View reviewed changes

JacobBarthelmeh merged commit fc51a38 into wolfSSL:master Apr 30, 2026
482 of 483 checks passed

Conversation

lealem47 commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lealem47 commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MemBrowse Memory Report

Uh oh!

Uh oh!

Uh oh!

julek-wolfssl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JacobBarthelmeh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lealem47 commented Apr 6, 2026 •

edited

Loading

lealem47 commented Apr 8, 2026 •

edited

Loading

github-actions Bot commented Apr 17, 2026 •

edited

Loading