Skip to content
Open
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
3072fec
Added more unit tests to increase branch coverage
danielinux Apr 13, 2026
f42a651
Fixes after rebasing to master
danielinux Apr 13, 2026
0b8ccf6
Fix tests regressions (kdf/macOS)
danielinux Apr 13, 2026
3d23695
Addressed copilot's comments
danielinux Apr 13, 2026
9ebb9bf
Fix test build due to kdf config mismatch
danielinux Apr 13, 2026
c1d5c61
Fix more test config mismatch. Codespell fixes.
danielinux Apr 13, 2026
afd9443
Fixed more configuration mismatches in tests
danielinux Apr 13, 2026
81c20e1
More configuration fixes
danielinux Apr 13, 2026
ecdc8c4
Disable extra wolfSSL_X509V3_EXT_i2d(...) checks in test_wolfSSL_X509…
danielinux Apr 13, 2026
6c7bc71
Fix failing tests
danielinux Apr 14, 2026
3a4a7e6
Fixed more test cases configurations
danielinux Apr 14, 2026
9ad9af5
Fix runtime error tls_mcdc, fixed correct MAP symbols
danielinux Apr 14, 2026
c13dcdd
Fixed mix-decl-and-code leftover
danielinux Apr 14, 2026
e4fc749
Fix AES test conflict resolution
danielinux Apr 15, 2026
8e595ce
Handle reduced AES key sizes in AES coverage tests
danielinux Apr 15, 2026
c1699bb
Make DH ASN NULL-input test parser-aware
danielinux Apr 15, 2026
2666b54
Fix source-text and static-analysis regressions
danielinux Apr 15, 2026
af50118
Stabilize TLS13 and ECH test flows
danielinux Apr 15, 2026
cf39c73
Fix AES-XTS test cleanup under sanitizer
danielinux Apr 15, 2026
617ff4a
Free AIA entries in X509 extension tests
danielinux Apr 15, 2026
75aa849
Fix unresolved Copilot review issues
danielinux Apr 15, 2026
2bbbe34
Stabilize TLS13 post-handshake auth coverage test
danielinux Apr 15, 2026
eaf7378
Restore WOLF_CRYPTO_CB_FIND allowlist entry
danielinux Apr 15, 2026
b4e8e06
Harden AES and ASN coverage tests for CI variants
danielinux Apr 15, 2026
a7e4cfc
Guard ASN DH NULL-arg coverage for parser variants
danielinux Apr 15, 2026
7c94714
Stabilize flaky CI tests and OCSP port reuse
danielinux Apr 15, 2026
e7aa81c
Relax ECH sub-TLS expectation across configs
danielinux Apr 15, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .wolfssl_known_macro_extras
Original file line number Diff line number Diff line change
Expand Up @@ -434,10 +434,12 @@ NO_POLY1305_ASM
NO_PUBLIC_CCM_SET_NONCE
NO_PUBLIC_GCM_SET_IV
NO_QAT_RNG
NO_RC2
NO_RESUME_SUITE_CHECK
NO_RNG
NO_RNG_MUTEX
NO_SESSION_CACHE_ROW_LOCK
NO_SHA384
NO_SKID
NO_SKIP_PREVIEW
NO_STDIO_FGETS_REMAP
Expand Down
53 changes: 48 additions & 5 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -1663,23 +1663,58 @@ tryliboqsdir=""
AC_ARG_WITH([liboqs],
[AS_HELP_STRING([--with-liboqs=PATH],[Path to liboqs install (default /usr/local) (requires --enable-experimental)])],
[
liboqs_saved_CPPFLAGS="$CPPFLAGS"
liboqs_saved_LDFLAGS="$LDFLAGS"
liboqs_saved_LIBS="$LIBS"
liboqs_saved_PKG_CONFIG_PATH="$PKG_CONFIG_PATH"
liboqs_pkgconfig_flags=""
liboqs_pkgconfig_libs=""
liboqs_link_libs="-loqs"
liboqs_user_cppflags=""
liboqs_user_ldflags=""

AS_IF([ test "$ENABLED_EXPERIMENTAL" != "yes" ],[ AC_MSG_ERROR([LIBOQS requires --enable-experimental.]) ])
AC_MSG_CHECKING([for liboqs])
LIBS="$LIBS -loqs"
AM_CFLAGS="$AM_CFLAGS -pthread"

if test "x$withval" != "xno" && test "x$withval" != "xyes"; then
tryliboqsdir=$withval
fi
if test "x$withval" = "xyes"; then
tryliboqsdir="/usr/local"
fi

if test -n "$tryliboqsdir" && test -d "$tryliboqsdir/lib/pkgconfig"; then
PKG_CONFIG_PATH="$tryliboqsdir/lib/pkgconfig${PKG_CONFIG_PATH+:$PKG_CONFIG_PATH}"
fi

if command -v pkg-config >/dev/null 2>&1 && \
PKG_CONFIG_PATH="$PKG_CONFIG_PATH" pkg-config --exists liboqs; then
liboqs_pkgconfig_flags=`PKG_CONFIG_PATH="$PKG_CONFIG_PATH" pkg-config --cflags liboqs`
liboqs_pkgconfig_libs=`PKG_CONFIG_PATH="$PKG_CONFIG_PATH" pkg-config --static --libs liboqs`
liboqs_link_libs="$liboqs_pkgconfig_libs"
liboqs_user_cppflags="$liboqs_pkgconfig_flags"
CPPFLAGS="$CPPFLAGS $liboqs_pkgconfig_flags -DHAVE_LIBOQS -DHAVE_TLS_EXTENSIONS -pthread"
LIBS="$LIBS $liboqs_pkgconfig_libs"
else
LIBS="$LIBS -loqs"
fi
Comment thread
danielinux marked this conversation as resolved.

AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <oqs/common.h>]], [[ OQS_init(); ]])], [ liboqs_linked=yes ],[ liboqs_linked=no ])
Comment on lines +1691 to 1703
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link test adds -DHAVE_LIBOQS -DHAVE_TLS_EXTENSIONS -pthread to CPPFLAGS (line 1697), but the values are later restored (lines 1736-1739) and only liboqs_user_cppflags is preserved (which, in the pkg-config path, appears to be just cflags). If the build relies on these defines/flags (as the previous logic did), liboqs-enabled builds may compile without HAVE_LIBOQS/related defines. Consider persisting required compile defines/flags into AM_CPPFLAGS (or an AC_DEFINE for HAVE_LIBOQS) and ensuring -pthread is consistently applied for the final build, not only for the configure-time probe.

Copilot uses AI. Check for mistakes.

if test "x$liboqs_linked" = "xno" ; then
if test "x$withval" != "xno" ; then
tryliboqsdir=$withval
fi
CPPFLAGS="$liboqs_saved_CPPFLAGS"
LDFLAGS="$liboqs_saved_LDFLAGS"
LIBS="$liboqs_saved_LIBS -loqs"

if test "x$withval" = "xyes" ; then
tryliboqsdir="/usr/local"
fi

CPPFLAGS="$AM_CPPFLAGS -DHAVE_LIBOQS -DHAVE_TLS_EXTENSIONS -I$tryliboqsdir/include -pthread"
LDFLAGS="$AM_LDFLAGS $LDFLAGS -L$tryliboqsdir/lib"
LDFLAGS="$AM_LDFLAGS $liboqs_saved_LDFLAGS -L$tryliboqsdir/lib"
liboqs_user_cppflags="-I$tryliboqsdir/include"
liboqs_user_ldflags="-L$tryliboqsdir/lib"

AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <oqs/common.h>]], [[ OQS_init(); ]])], [ liboqs_linked=yes ],[ liboqs_linked=no ])

Expand All @@ -1692,8 +1727,16 @@ AC_ARG_WITH([liboqs],
AM_LDFLAGS="$AM_LDFLAGS -L$tryliboqsdir/lib"
else
AC_MSG_RESULT([yes])
AM_CPPFLAGS="$AM_CPPFLAGS $liboqs_pkgconfig_flags"
fi

LIB_ADD="$LIB_ADD $liboqs_link_libs"

PKG_CONFIG_PATH="$liboqs_saved_PKG_CONFIG_PATH"
CPPFLAGS="$liboqs_saved_CPPFLAGS $liboqs_user_cppflags"
LDFLAGS="$liboqs_saved_LDFLAGS $liboqs_user_ldflags"
LIBS="$liboqs_saved_LIBS"
Comment on lines +1734 to +1739
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link test adds -DHAVE_LIBOQS -DHAVE_TLS_EXTENSIONS -pthread to CPPFLAGS (line 1697), but the values are later restored (lines 1736-1739) and only liboqs_user_cppflags is preserved (which, in the pkg-config path, appears to be just cflags). If the build relies on these defines/flags (as the previous logic did), liboqs-enabled builds may compile without HAVE_LIBOQS/related defines. Consider persisting required compile defines/flags into AM_CPPFLAGS (or an AC_DEFINE for HAVE_LIBOQS) and ensuring -pthread is consistently applied for the final build, not only for the configure-time probe.

Copilot uses AI. Check for mistakes.

if test "x$ENABLED_OPENSSLEXTRA" = "xno" && test "x$ENABLED_OPENSSLCOEXIST" = "xno"
then
ENABLED_OPENSSLEXTRA="yes"
Expand Down
Loading
Loading