Skip to content

20260415-confusing_globals#10232

Merged
dgarske merged 3 commits intowolfSSL:masterfrom
douzzer:20260415-confusing_globals
Apr 15, 2026
Merged

20260415-confusing_globals#10232
dgarske merged 3 commits intowolfSSL:masterfrom
douzzer:20260415-confusing_globals

Conversation

@douzzer
Copy link
Copy Markdown
Contributor

@douzzer douzzer commented Apr 15, 2026

src/ssl_load.c, wolfssl/ssl.h, tests/api.c: rename wolfSSL*PrivateKey_id() to wolfSSL*PrivateKey_Id_ex(), and add missing WOLF_PRIVATE_KEY_ID gating.

src/ssl.c, src/ssl_sess.c, src/x509.c, wolfssl/internal.h: rename wolfssl_get_ex_new_index() to wolfssl_local_get_ex_new_index().

tested with

wolfssl-multi-test.sh ...
super-quick-check
check-for-bad-symbols

Note check-for-bad-symbols is the old check-for-unprefixed-symbols, now with callouts to a newly implemented check_libwolfssl_for_confusing_globals() for each sub-scenario. Currently check_libwolfssl_for_confusing_globals() just checks for globals (either public or hidden) that have the same name when case-folded. There is one unavoidable exception, wolfSSL_Free() and wolfSSL_free(), the former our public name for our free() wrapper, the latter our public name for our API to free a WOLFSSL *. Both were added in v3.3.3 (Jan 9 2015), both deriving from CyaSSL variants added in v2.0.2 (Dec 5 2011). We're stuck with those.

douzzer added 2 commits April 15, 2026 11:53
…_id() to wolfSSL*PrivateKey_Id_ex(), and add missing WOLF_PRIVATE_KEY_ID gating.
…fssl_get_ex_new_index() to wolfssl_local_get_ex_new_index().
Copy link
Copy Markdown

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10232

Scan targets checked: wolfssl-bugs, wolfssl-compliance, wolfssl-consttime, wolfssl-defaults, wolfssl-mutation, wolfssl-proptest, wolfssl-src, wolfssl-zeroize

No new issues found in the changed files. ✅

Comment thread wolfssl/ssl.h
@douzzer douzzer requested a review from dgarske April 15, 2026 17:31
@douzzer
Copy link
Copy Markdown
Contributor Author

douzzer commented Apr 15, 2026

retest this please
(mystery failure on "140-3 tests", no specific test failure show)

@github-actions
Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@dgarske dgarske merged commit 26a7d59 into wolfSSL:master Apr 15, 2026
432 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants