20260415-confusing_globals#10232
Merged
dgarske merged 3 commits intowolfSSL:masterfrom Apr 15, 2026
Merged
Conversation
…_id() to wolfSSL*PrivateKey_Id_ex(), and add missing WOLF_PRIVATE_KEY_ID gating.
…fssl_get_ex_new_index() to wolfssl_local_get_ex_new_index().
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10232
Scan targets checked: wolfssl-bugs, wolfssl-compliance, wolfssl-consttime, wolfssl-defaults, wolfssl-mutation, wolfssl-proptest, wolfssl-src, wolfssl-zeroize
No new issues found in the changed files. ✅
dgarske
requested changes
Apr 15, 2026
dgarske
approved these changes
Apr 15, 2026
Frauschi
approved these changes
Apr 15, 2026
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/ssl_load.c,wolfssl/ssl.h,tests/api.c: renamewolfSSL*PrivateKey_id()towolfSSL*PrivateKey_Id_ex(), and add missingWOLF_PRIVATE_KEY_IDgating.src/ssl.c,src/ssl_sess.c,src/x509.c,wolfssl/internal.h: renamewolfssl_get_ex_new_index()towolfssl_local_get_ex_new_index().tested with
Note
check-for-bad-symbolsis the oldcheck-for-unprefixed-symbols, now with callouts to a newly implementedcheck_libwolfssl_for_confusing_globals()for each sub-scenario. Currentlycheck_libwolfssl_for_confusing_globals()just checks for globals (either public or hidden) that have the same name when case-folded. There is one unavoidable exception,wolfSSL_Free()andwolfSSL_free(), the former our public name for ourfree()wrapper, the latter our public name for our API to free aWOLFSSL *. Both were added in v3.3.3 (Jan 9 2015), both deriving from CyaSSL variants added in v2.0.2 (Dec 5 2011). We're stuck with those.