Phase 3: SHA512 integrity check and closing the final FIPS requirements gaps#10281
Open
kaleb-himes wants to merge 1 commit intowolfSSL:masterfrom
Open
Phase 3: SHA512 integrity check and closing the final FIPS requirements gaps#10281kaleb-himes wants to merge 1 commit intowolfSSL:masterfrom
kaleb-himes wants to merge 1 commit intowolfSSL:masterfrom
Conversation
kaleb-himes
force-pushed
the
PQ-FS-2026-Part3-SecurityReview
branch
3 times, most recently
from
8923ea5 to
9af5352
Compare
|
kaleb-himes
changed the title
kaleb-himes
force-pushed
the
PQ-FS-2026-Part3-SecurityReview
branch
3 times, most recently
from
a43af0f to
7c0c87a
Compare
Frauschi
requested changes
Apr 30, 2026
Contributor
Frauschi
left a comment
Frauschi
left a comment
There was a problem hiding this comment.
Only found one small possible memory usage optimization. Otherwise LGTM
| * is used because SLH-DSA signatures can reach ~50 KB. */ | ||
| if (ret == 0) { | ||
| static const byte pct_msg[] = "wolfSSL SLH-DSA PCT"; | ||
| byte* pct_sig = (byte*)XMALLOC(WC_SLHDSA_MAX_SIG_LEN, NULL, |
Contributor
There was a problem hiding this comment.
At this point in the function, we know which parameter/variant we have. Hence, we know the exact signature length here and can therefore allocate an exact-sized signature buffer. Due to the high variance of SLH-DSA signature size, this can dramatically reduce the heap usage here.
kaleb-himes
force-pushed
the
PQ-FS-2026-Part3-SecurityReview
branch
5 times, most recently
from
f1d3f27 to
858c6c9
Compare
….2 + 20.1 + 6.2: integrity, PCT, zeroize, CMAC/SHAKE/AES-KW CASTs, DH PCT + configurable DRBG_SHA512_SEED_LEN, ML-DSA sign privateKeyReadEnable parity, FIPS CAST benchmark deliverable, RSA 1024 removed from FIPS RsaSizeCheck, linuxkm AES-GCM tag-min 96-bit FIPS gate 6.2 (Medium): The pre-existing linuxkm relaxation of WOLFSSL_MIN_AUTH_TAG_SZ to 4 bytes (32 bits) in wolfssl/wolfcrypt/settings.h is now gated by #ifndef HAVE_FIPS. FIPS-mode linuxkm builds revert to the standard 96-bit (12-byte) minimum mandated by NIST SP 800-38D sec 5.2.1.2 / sec 8.2 and FIPS 140-3 IG C.H. Non-FIPS linuxkm builds retain the 32-bit-tag relaxation for kernel crypto manager test vector compatibility.
kaleb-himes
force-pushed
the
PQ-FS-2026-Part3-SecurityReview
branch
from
858c6c9 to
7e935ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please describe the scope of the fix or feature addition.
Fixes zd#
Testing
How did you test?
Checklist