Fix W560 "possible truncation at implicit conversion to type unsigned char" warnings raised by Tasking compiler.#10282
Merged
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom Apr 24, 2026
Conversation
… char" warnings raised by Tasking compiler.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Tasking compiler W560 warnings by making narrowing conversions explicit and by guarding an LwIP send length conversion to a 16-bit type.
Changes:
- Add explicit
(byte)casts when storingword32/carry values intobytebuffers in low-memory field element operations. - Add explicit cast for TLS 1.3
GetNewSAHashAlgo()result when assigning into abyte. - Add range-check and explicit
(u16_t)cast before passingszintolwIP’stcp_write().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| wolfcrypt/src/fe_low_mem.c | Makes byte truncations explicit in Curve25519/Ed25519 small/low-mem math helpers. |
| src/wolfio.c | Adds size validation and explicit 16-bit cast for LwIP native send path. |
| src/tls13.c | Makes enum-to-byte narrowing conversion explicit when decoding TLS 1.3 signature algorithms. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
JacobBarthelmeh
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21527
Testing
Built in tests, customer confirmed fix
Checklist