Skip to content

Increase hostap retry count#10389

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
Frauschi:hostap
May 5, 2026
Merged

Increase hostap retry count#10389
dgarske merged 1 commit intowolfSSL:masterfrom
Frauschi:hostap

Conversation

@Frauschi
Copy link
Copy Markdown
Contributor

@Frauschi Frauschi commented May 4, 2026

Retry hostap tests up to 2 times to reduce flakyness.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

MemBrowse Memory Report

No memory changes detected for:

Copy link
Copy Markdown
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is the action will never fail. You don't actually do anything with the HWSIM_RES value.

Copy link
Copy Markdown
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is the action will never fail. You don't actually do anything with the HWSIM_RES value.

@Frauschi
Copy link
Copy Markdown
Contributor Author

Frauschi commented May 4, 2026

PR updated. Test now fails if none of the tries succeed.

@julek-wolfssl julek-wolfssl requested a review from Copilot May 4, 2026 16:10
julek-wolfssl
julek-wolfssl previously approved these changes May 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the hostap VM GitHub Actions workflow to reduce CI flakiness by retrying failed upstream hostap test cases before failing the job.

Changes:

  • Add up to 2 retries for failed vm/parallel-vm.py test runs.
  • Replace the prior single re-run behavior with explicit retry logic and a hard failure if tests still fail after retries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/hostap-vm.yml Outdated
Comment thread .github/workflows/hostap-vm.yml Outdated
@Frauschi
Copy link
Copy Markdown
Contributor Author

Frauschi commented May 4, 2026

Fixed the Copilot findings.

@dgarske dgarske merged commit ba51328 into wolfSSL:master May 5, 2026
422 of 424 checks passed
@Frauschi Frauschi deleted the hostap branch May 5, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants