support build --enable-opensslextra with NO_BIO and NO_FILESYSTEM #10393
Open
JacobBarthelmeh wants to merge 2 commits intowolfSSL:masterfrom
Open
support build --enable-opensslextra with NO_BIO and NO_FILESYSTEM #10393JacobBarthelmeh wants to merge 2 commits intowolfSSL:masterfrom
JacobBarthelmeh wants to merge 2 commits intowolfSSL:masterfrom
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10393
Scan targets checked: wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts OpenSSL-compat and API tests so --enable-opensslextra builds cleanly when both NO_BIO and NO_FILESYSTEM are enabled. It primarily narrows test/build coverage to configurations that still have the required I/O backends, while making a couple of DER-only helpers available without BIO support.
Changes:
- Guard filesystem-dependent TLS API tests so they are skipped when
NO_FILESYSTEMis enabled. - Guard the BIO-only EC test block so it is skipped when
NO_BIOis enabled. - Relax internal compile guards in
pk_ec.c/pk_rsa.cand add a CI matrix entry for--enable-opensslextra --disable-filesystem CPPFLAGS="-DNO_BIO".
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/api/test_tls13.c |
Skips several cert-file-based TLS 1.3 tests when filesystem support is disabled. |
tests/api/test_tls.c |
Skips a TLS 1.2 cert-file-based test when filesystem support is disabled. |
tests/api/test_ossl_ec.c |
Wraps a BIO-dependent EC public-key decode check with #ifndef NO_BIO. |
src/pk.c |
Restricts DER→PEM helper compilation to configs with either BIO or filesystem output available. |
src/pk_rsa.c |
Makes the internal DER-to-RSA loader available independent of BIO/filesystem guards. |
src/pk_ec.c |
Makes DER-based EC parameter decode/encode available without requiring BIO support. |
.github/workflows/os-check.yml |
Adds CI coverage for OPENSSL_EXTRA + NO_BIO + NO_FILESYSTEM. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.