Fix X509 load locations to handle PEM files with multiple certs#8850
Open
ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
Open
Fix X509 load locations to handle PEM files with multiple certs#8850ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
Author
|
Retest this please. Found unhandled hudson.remoting.RequestAbortedException exception: |
julek-wolfssl
requested changes
Jun 9, 2025
julek-wolfssl
previously requested changes
Jun 13, 2025
Member
julek-wolfssl
left a comment
julek-wolfssl
left a comment
There was a problem hiding this comment.
Please move the new tests and check if the CRL functionality is tested somewhere.
dgarske
assigned
ColtonWilley and
wolfSSL-Bot and unassigned
ColtonWilley and
wolfSSL-Bot
dgarske
previously approved these changes
Jul 3, 2025
SparkiDev
previously approved these changes
Jul 7, 2025
julek-wolfssl
previously approved these changes
Jul 7, 2025
Member
|
@ColtonWilley please rebase to run all the latest tests. |
ColtonWilley
dismissed stale reviews from dgarske, SparkiDev, and julek-wolfssl
via
1c8e62f
Adds X509LoadPemFile to walk multi-cert PEM files when loading via wolfSSL_X509_STORE_load_locations and X509_LOOKUP_load_file, replacing the single-cert helpers X509StoreReadFile/X509StoreLoadFile which only read the first cert from a file. Rebased fresh onto current upstream master (was 2209 commits behind); test additions deferred to a follow-up since the test file layout has been reorganized in master.
ColtonWilley
force-pushed
the
x509_store_pem_multi
branch
from
1c8e62f to
e1373f0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wolfSSL_X509_load_locations() previously did not handle PEM files with multiple certs in one file, only the first cert would be loaded. Modify wolfSSL_X509_load_locations() to fix this by using existing logic in x509.c to loop over the PEM headers and load each item, cert or CRL.
Fixes zd 19835
Checklist