Introduce sm-cipher workflow tests to wolfssl#9193
Introduce sm-cipher workflow tests to wolfssl#9193gojimmypi wants to merge 1 commit intowolfSSL:masterfrom
Conversation
|
@gojimmypi does this need rebased after the SM fix was merged? I manually clicked to re-run the SM GitHub action test and it failed at the same location. |
f3d09cd to
02c314f
Compare
|
Hi @JacobBarthelmeh - yes, the new Now that it is merged, I've refreshed from upstream and confirmed the new test runs successfully in this PR. |
|
Jenkins retest this please. For org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException: Unable to create live FilePath for wolf-linux-cloud-node-[n]; wolf-linux-cloud-node-[n] was marked offline: Connection was broken |
2446464 to
05ce15d
Compare
|
The SM Cipher test over in wolfsm repo should be nearly identical to this one. After code review there, I've updated the |
|
Jenkins retest this please For StreamCorruptedException: invalid stream header: 636F7272 |
| @@ -0,0 +1,194 @@ | |||
| name: SM Cipher Test (1 of 2) | |||
| # | |||
| # Test fetches wolfssl-examples/Arduino and uses local, latest github master branch wolfssl | |||
There was a problem hiding this comment.
Fix comment... Arduino is not part of this test.
There was a problem hiding this comment.
Same issue with other sm-cipher.yml. https://github.com/wolfSSL/wolfsm/blob/master/.github/workflows/sm-cipher.yml#L3C33-L3C40
| @@ -0,0 +1,194 @@ | |||
| name: SM Cipher Test (1 of 2) | |||
There was a problem hiding this comment.
Why do we need a sm-cipher test in wolfSSL and also in wolfSM? Why duplicated? I recommend only having the one in wolfsm and adding rules to run automatically on schedule. https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#schedule
|
Can one of the admins verify this patch? |
|
Closed since tests are added here #9795 |
Description
This PR introduces SM ShangMi cipher tests in GitHub workflow for the wolfssl repo.
The SM TLS 1.3 is currently not working properly; Thus this PR can be merged as-is to show that, or wait until #9175 is merged. I could also temporarily disable the TLS 1.3 tests in this PR.See sample action history: https://github.com/gojimmypi/wolfssl/actions/workflows/sm-cipher.yml
(failing as expected on current pr-sm-cipher-test butworking on espressif-latest-debug with the needed #9175 patch)See also:
I also have a WIP wolfsm companion
SM Cipher Test (2 of 2)test. See sample for that. Update: merged in wolfsm #28SM tests are currently failing there in the(merged)wolfsmrepo as I do not manually apply the needed patch from #9175 .Update: Example GitHub Actions Output:
Fixes zd# n/a
Testing
Tested on my branches:
Checklist