Rust wrapper: add mlkem module#9833
Merged
douzzer merged 4 commits intowolfSSL:masterfrom Mar 5, 2026
Merged
Conversation
Contributor
Author
|
retest this please (ERROR: wolfSSL » PRB-140-3-tests #8576 was deleted) |
gasbytes
reviewed
Feb 26, 2026
gasbytes
requested changes
Feb 26, 2026
Contributor
Author
|
retest this please (build removed) |
gasbytes
previously approved these changes
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an ML-KEM (post-quantum KEM) Rust wrapper module to the wolfCrypt Rust bindings, along with CI enablement and unit tests.
Changes:
- Introduces
mlkemRust module wrapping wolfCrypt ML-KEM key lifecycle and operations (generate/encap/decap/encode/decode). - Adds ML-KEM unit tests covering constants, size queries, deterministic APIs, and encap/decap flows.
- Extends bindings/CI to expose and build ML-KEM (
headers.h,build.rscfg scan, GitHub workflow).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| wrapper/rust/wolfssl-wolfcrypt/src/mlkem.rs | New ML-KEM wrapper API (key management + KEM operations) |
| wrapper/rust/wolfssl-wolfcrypt/tests/test_mlkem.rs | New unit tests for ML-KEM wrapper behavior |
| wrapper/rust/wolfssl-wolfcrypt/src/lib.rs | Exposes the new mlkem module from the crate |
| wrapper/rust/wolfssl-wolfcrypt/headers.h | Adds wolfcrypt/mlkem.h to bindings header set |
| wrapper/rust/wolfssl-wolfcrypt/build.rs | Enables cfg(mlkem) detection in build-time symbol scan |
| .github/workflows/rust-wrapper.yml | Adds a CI matrix entry building wolfSSL with --enable-mlkem |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
retest this please (Failed make check with enable all + openssl all) |
gasbytes
approved these changes
Mar 3, 2026
gasbytes
approved these changes
Mar 3, 2026
douzzer
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rust wrapper: add mlkem module
Testing
Unit tests
Checklist