Skip to content

Fix unused variable warning in PKCS7 without WC_RSA_PSS #9837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 2 commits into from
Feb 27, 2026
+4 −0
Merged

Fix unused variable warning in PKCS7 without WC_RSA_PSS #9837

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f9dd3c
Fix unused variable warning in PKCS7 without WC_RSA_PSS
jackctj117 Feb 26, 2026
e6d4c55
Move paramsStart declaration inside WC_RSA_PSS guard
jackctj117 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/os-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ jobs:
CPPFLAGS=''-DWC_RNG_SEED_CB -DWOLFSSL_NO_GETPID'' ',
# PKCS#7 with RSA-PSS (CMS RSASSA-PSS signers)
'--enable-pkcs7 CPPFLAGS=-DWC_RSA_PSS',
# PKCS#7 without RSA-PSS
'--enable-pkcs7',
'--enable-opensslextra CPPFLAGS=''-DWOLFSSL_NO_CA_NAMES'' ',
'--enable-opensslextra=x509small',
'CPPFLAGS=''-DWOLFSSL_EXTRA'' ',
Expand Down
3 changes: 3 additions & 0 deletions wolfcrypt/src/pkcs7.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5445,6 +5445,9 @@ static int wc_PKCS7_ParseSignerInfo(wc_PKCS7* pkcs7, byte* in, word32 inSz,
ret = ASN_PARSE_E;
}
else {
#if !defined(WC_RSA_PSS) || defined(NO_RSA)
(void)paramsStart;
Comment thread
dgarske marked this conversation as resolved.
Outdated
#endif
#if defined(WC_RSA_PSS) && !defined(NO_RSA)
if ((word32)sigOID == (word32)CTC_RSASSAPSS &&
paramTag == (ASN_SEQUENCE | ASN_CONSTRUCTED)) {
Expand Down