Skip to content

Re-enable hostap tests and remove some flaky tests#9841

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
julek-wolfssl:hostap-ec-generate.sh
Mar 23, 2026
Merged

Re-enable hostap tests and remove some flaky tests#9841
dgarske merged 1 commit intowolfSSL:masterfrom
julek-wolfssl:hostap-ec-generate.sh

Conversation

@julek-wolfssl
Copy link
Copy Markdown
Member

Set suites->setSuites to 1 in ParseCipherList function

Copilot AI review requested due to automatic review settings February 27, 2026 16:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-enables the hostap/wpa-supplicant GitHub Actions workflow on push/PR and adjusts cipher suite parsing behavior to mark default suites as explicitly set, while also removing a subset of flaky hostap tests.

Changes:

  • Set suites->setSuites when falling back to the wolfSSL default cipher list.
  • Re-enable the hostap-vm workflow for push and pull_request events and expand the certificate regeneration step.
  • Remove several flaky tests from pinned hostap config test lists.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/internal.c Marks the default cipher suite list as “set” when ParseCipherList falls back to wolfSSL defaults.
.github/workflows/hostap-vm.yml Re-enables CI triggers and updates the order/steps for regeneration of hostap auth_serv certs.
.github/workflows/hostap-files/configs/b607d2723e927a3446d89aed813f1aa6068186bb/tests Removes specific flaky tests from this pinned hostap test list.
.github/workflows/hostap-files/configs/07c9f183ea744ac04585fb6dd10220c75a5e2e74/tests Removes specific flaky tests from this pinned hostap test list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/hostap-vm.yml
@dgarske
Copy link
Copy Markdown
Member

dgarske commented Mar 19, 2026

Jenkins retest this please - M1 never ran

@dgarske
Copy link
Copy Markdown
Member

dgarske commented Mar 20, 2026

Jenkins retest this please - history lost. The M1 failure in unit test doesn't appear to be related.

@julek-wolfssl julek-wolfssl removed their assignment Mar 23, 2026
Set suites->setSuites to 1 in ParseCipherList function
@julek-wolfssl julek-wolfssl force-pushed the hostap-ec-generate.sh branch from d717013 to 4498e12 Compare March 23, 2026 14:28
@dgarske
Copy link
Copy Markdown
Member

dgarske commented Mar 23, 2026

@julek-wolfssl not sure why but your PR is failing

https://cloud.wolfssl-test.com/jenkins/job/PRB-multi-test-script/10005/pipeline-overview/

[all-c89-clang-tidy] [1 of 1] [wolfssl]
    autogen.sh wolfssl...   real 0m15.620s  user 0m13.065s  sys 0m0.299s
    configure...   real 0m16.147s  user 0m10.951s  sys 0m4.338s
    build...   real 16m27.691s  user 14m43.606s  sys 0m21.064s
    check...FAIL: scripts/ocsp-stapling-with-wolfssl-responder.test
   real 1m2.303s  user 0m33.029s  sys 0m3.226s
scripts/ocsp-stapling-with-wolfssl-responder.log tail:
Received 189 bytes
OCSP request: 68 bytes, path: /
Generated OCSP response: 1726 bytes
Processed request 11
Connection from 127.0.0.1:58012
Received 189 bytes
OCSP request: 68 bytes, path: /
Generated OCSP response: 1726 bytes
Processed request 12
FAIL scripts/ocsp-stapling-with-wolfssl-responder.test (exit status: 1)

@dgarske
Copy link
Copy Markdown
Member

dgarske commented Mar 23, 2026

Merging with multi-test issues (not related)

@dgarske dgarske merged commit 54d6555 into wolfSSL:master Mar 23, 2026
499 of 500 checks passed
douzzer added a commit to douzzer/wolfssl that referenced this pull request Mar 23, 2026
@douzzer douzzer mentioned this pull request Mar 23, 2026
JeremiahM37 pushed a commit to JeremiahM37/wolfssl that referenced this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants