Skip to content

fix(aggregation_mode): unused import: Prover in src/aggregators/sp1_aggregator.rs:6:29#1924

Closed
JuArce wants to merge 1 commit intostagingfrom
1923-fixaggregation_mode-unused-import-prover-in-srcaggregatorssp1_aggregatorrs629
Closed

fix(aggregation_mode): unused import: Prover in src/aggregators/sp1_aggregator.rs:6:29#1924
JuArce wants to merge 1 commit intostagingfrom
1923-fixaggregation_mode-unused-import-prover-in-srcaggregatorssp1_aggregatorrs629

Conversation

@JuArce
Copy link
Copy Markdown
Collaborator

@JuArce JuArce commented May 8, 2025

Unused import: Prover in src/aggregators/sp1_aggregator.rs:6:29

Description

Remove unused import to avoid warnings

How to test

  1. Run anvil
make anvil_start
  1. Run batcher
make batcher_start_local
  1. Send some proofs
make batcher_send_risc0_burst BURST_SIZE=8
make batcher_send_so1_burst BURST_SIZE=8 
  1. Run aggregation mode
make start_proof_aggregator_dev AGGREGATOR=sp1
make start_proof_aggregator_dev AGGREGATOR=risc0
  1. You should not see warnings during compilation process

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce self-assigned this May 8, 2025
@JuArce JuArce marked this pull request as draft May 8, 2025 19:34
@JuArce
Copy link
Copy Markdown
Collaborator Author

JuArce commented May 8, 2025

The warning appears depending on which target we are running

@JuArce JuArce closed this May 8, 2025
@JuArce JuArce deleted the 1923-fixaggregation_mode-unused-import-prover-in-srcaggregatorssp1_aggregatorrs629 branch May 8, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant