Skip to content

fix: update explorer URL printed after proof submission #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuArce merged 5 commits into from
Jun 24, 2025
Merged

fix: update explorer URL printed after proof submission #1989

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5baa2f
Handle different urls for different networks
maximopalopoli Jun 18, 2025
14add19
Add comment explaining the url used as default is the mainnet one
maximopalopoli Jun 18, 2025
2909fb3
clone the last network arg use to fix compilation
maximopalopoli Jun 18, 2025
c5b2f65
Add arms for each network on the network enum and set devnet as default
maximopalopoli Jun 23, 2025
e5c7bcf
Fix the stage and mannet stage urls
maximopalopoli Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions crates/cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ async fn main() -> Result<(), AlignedError> {
info!("Submitting proofs to the Aligned batcher...");

let aligned_verification_data_vec = submit_multiple(
submit_args.network.into(),
submit_args.network.clone().into(),
&verification_data_arr,
max_fee_wei,
wallet.clone(),
Expand Down Expand Up @@ -622,9 +622,16 @@ async fn main() -> Result<(), AlignedError> {
}

for batch_merkle_root in unique_batch_merkle_roots {
let base_url = match submit_args.network.clone().into() {
// Note: in case the explorer address changes for other networks, we should add an arm to this
// match with that network since the default URL used here is the mainnet one
Network::Holesky => "https://holesky.explorer.alignedlayer.com/batches/0x",
Copy link
Copy Markdown
Collaborator

@JuArce JuArce Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing to add the other networks

  • Stage
  • Mainnet
  • MainnetStage
  • Devnet

Generally we use devnet as default

Copy link
Copy Markdown
Contributor Author

@maximopalopoli maximopalopoli Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in c5b2f65

_ => "https://explorer.alignedlayer.com/batches/0x",
};

info!(
"https://explorer.alignedlayer.com/batches/0x{}",
hex::encode(batch_merkle_root)
"{}",
base_url.to_string() + hex::encode(batch_merkle_root).as_str()
);
}
}
Expand Down
Loading