Skip to content

fix: improve concurrency handling of users #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcosNicolau wants to merge 20 commits into from
Closed

fix: improve concurrency handling of users #2014

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
08d51b6
feat: move verification after the message and replamcents validations
MarcosNicolau Jun 30, 2025
766fa70
feat: proof processing via channels
MarcosNicolau Jun 30, 2025
f48157d
feat: lock per user implementation
MarcosNicolau Jun 30, 2025
44c36e6
feat: batch building mutex
MarcosNicolau Jun 30, 2025
ef8c9a3
refactor: move user update to batch state
MarcosNicolau Jul 1, 2025
d25bef1
chore: address clippy warnings
MarcosNicolau Jul 1, 2025
653283c
fix: handle block don't spawn a new task for it
MarcosNicolau Jul 1, 2025
067b64a
chore: better tracing for debug mode
MarcosNicolau Jul 1, 2025
4aabc53
fix: remove sleep from verify_proof
MarcosNicolau Jul 1, 2025
ae55834
chore: remove proof processor
MarcosNicolau Jul 1, 2025
6cdf54e
feat: priority for batch building process when acquiring user locks
MarcosNicolau Jul 1, 2025
26b1641
refactor: naming, docs, logs, style
MarcosNicolau Jul 1, 2025
7a7df60
fix: clone user_proof_processing_mutexes to prevent deadlock
MarcosNicolau Jul 1, 2025
30b7c44
fix: task-sender generate proofs target
MarcosNicolau Jul 2, 2025
a46bf2c
refactor: improvements over locks and code style
MarcosNicolau Jul 2, 2025
8837ea4
refactor: remove building_batch_mutex and sync between proof processi…
MarcosNicolau Jul 3, 2025
c48c272
docs: batcher mutexes
MarcosNicolau Jul 3, 2025
96def6c
refactor: comments, tracing and err messages
MarcosNicolau Jul 3, 2025
8787958
fix: move batch queue full condition to add_to_batch
MarcosNicolau Jul 10, 2025
a2c05bf
chore: show ethers_providers warn log level by default
MarcosNicolau Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ BURST_TIME_SECS ?= 3
task_sender_generate_gnark_groth16_proofs:
@cd crates/task-sender && \
cargo run --release -- generate-proofs \
--number-of-proofs $(NUMBER_OF_PROOFS) --proof-type gnark_groth16 \
--number-of-proofs $(NUMBER_OF_PROOFS) --proof-type groth16 \
Copy link
Copy Markdown
Collaborator

@JuArce JuArce Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted

Copy link
Copy Markdown
Member Author

@MarcosNicolau MarcosNicolau Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the gnark_groth16 wasn't added to the task-sender. We should update the commands args in the task sender first in other pr. I fixed that here because I used the task-sender to test.

--dir-to-save-proofs $(CURDIR)/scripts/test_files/task_sender/proofs

# ===== DEVNET =====
Expand Down
3 changes: 2 additions & 1 deletion crates/batcher/.env.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ AWS_ACCESS_KEY_ID=test
AWS_BUCKET_NAME=aligned.storage
UPLOAD_ENDPOINT=http://localhost:4566
DOWNLOAD_ENDPOINT=http://localhost:4566/aligned.storage
RUST_LOG=info
# Override default logs filter
# RUST_LOG=info
RUST_BACKTRACE=1
Loading
Loading