Skip to content

chore: remove dev mode functionality on Proof Aggregation Service contract #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuArce merged 17 commits into from
Dec 1, 2025
+12 −30
Merged

chore: remove dev mode functionality on Proof Aggregation Service contract #2176

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6ce5d48
fix: bump allow and send blobs in transaction with eip 7594
MarcosNicolau Nov 14, 2025
a81b73f
ci: bump rust version to support newer alloy version
MarcosNicolau Nov 14, 2025
c14107e
chore: ignore clippy uninlined_format_args warnings
MarcosNicolau Nov 19, 2025
4898009
chore: address clippy warnings
MarcosNicolau Nov 19, 2025
c88ec93
chore: address more clippy warnings
MarcosNicolau Nov 19, 2025
bb3786d
chore: address clippy warnings
MarcosNicolau Nov 19, 2025
7048c1b
chore: migrate ethereum package to fulu fork (#2173)
MarcosNicolau Nov 20, 2025
a6d0f7e
feat: have a dev mode flag set on initialize
maximopalopoli Nov 25, 2025
98dc9c7
update the aligned layer deployed anvil state
maximopalopoli Nov 25, 2025
55619b2
Merge branch 'testnet' into feat/dev-mode-flag-initialize
maximopalopoli Nov 26, 2025
0d48d3f
Move the immutable devmode flag from the initialize to the constructor
maximopalopoli Nov 26, 2025
295b7ce
Rename dev mode var to is dev mode
maximopalopoli Nov 26, 2025
752a96c
Merge branch 'testnet' into feat/dev-mode-flag-initialize
maximopalopoli Nov 26, 2025
b7642f9
chore: remove the dev mode functionality on ProofAggregationService c…
maximopalopoli Nov 27, 2025
60b37dc
Remove unused config file path on agg service upgrader
maximopalopoli Nov 27, 2025
32377a1
Merge branch 'testnet' into feat/dev-mode-flag-initialize
maximopalopoli Dec 1, 2025
9be34d9
Update the new contract state on network params
maximopalopoli Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contracts/script/upgrade/ProofAggregatorServiceUpgrader.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ import "forge-std/Script.sol";
import "forge-std/StdJson.sol";

contract AlignedProofAggregationServiceUpgrader is Script {
function run(string memory alignedLayerDeploymentFilePath) external returns (address, address) {
function run(string memory alignedLayerDeploymentFilePath, string memory proofAggregatorConfigFilePath) external returns (address, address) {
string memory aligned_deployment_file = vm.readFile(alignedLayerDeploymentFilePath);
string memory config_data = vm.readFile(proofAggregatorConfigFilePath);
Comment thread
JuArce marked this conversation as resolved.
Outdated

vm.startBroadcast();

Expand Down
2 changes: 1 addition & 1 deletion contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 5 additions & 23 deletions contracts/src/core/AlignedProofAggregationService.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ contract AlignedProofAggregationService is
/// https://dev.risczero.com/api/blockchain-integration/contracts/verifier#contract-addresses
address public risc0VerifierAddress;

/// @notice whether we are in dev mode or not
/// if the sp1 verifier address is set to this address, then we skip verification
address public constant VERIFIER_MOCK_ADDRESS = address(0xFF);

/// The unique identifier (image ID) of the RISC Zero aggregator program.
/// This ensures that only proofs generated by a trusted Risc0 program can be verified.
bytes32 public risc0AggregatorProgramImageId;
Expand Down Expand Up @@ -73,10 +69,7 @@ contract AlignedProofAggregationService is
{
(bytes32 merkleRoot) = abi.decode(sp1PublicValues, (bytes32));

// In dev mode, proofs are mocked, so we skip the verification part
if (_isSP1VerificationEnabled()) {
ISP1Verifier(sp1VerifierAddress).verifyProof(sp1AggregatorProgramVKHash, sp1PublicValues, sp1ProofBytes);
}
ISP1Verifier(sp1VerifierAddress).verifyProof(sp1AggregatorProgramVKHash, sp1PublicValues, sp1ProofBytes);

aggregatedProofs[merkleRoot] = true;
emit AggregatedProofVerified(merkleRoot, blobVersionedHash);
Expand All @@ -88,13 +81,10 @@ contract AlignedProofAggregationService is
{
(bytes32 merkleRoot) = abi.decode(risc0JournalBytes, (bytes32));

// In dev mode, proofs are mocked, so we skip the verification part
if (_isRisc0VerificationEnabled()) {
bytes32 risc0JournalDigest = sha256(risc0JournalBytes);
IRiscZeroVerifier(risc0VerifierAddress).verify(
risc0ReceiptSeal, risc0AggregatorProgramImageId, risc0JournalDigest
);
}
bytes32 risc0JournalDigest = sha256(risc0JournalBytes);
IRiscZeroVerifier(risc0VerifierAddress).verify(
risc0ReceiptSeal, risc0AggregatorProgramImageId, risc0JournalDigest
);

aggregatedProofs[merkleRoot] = true;
emit AggregatedProofVerified(merkleRoot, blobVersionedHash);
Expand Down Expand Up @@ -125,14 +115,6 @@ contract AlignedProofAggregationService is
return aggregatedProofs[merkleRoot];
}

function _isSP1VerificationEnabled() internal view returns (bool) {
return sp1VerifierAddress != VERIFIER_MOCK_ADDRESS;
}

function _isRisc0VerificationEnabled() internal view returns (bool) {
return risc0VerifierAddress != VERIFIER_MOCK_ADDRESS;
}

function _authorizeUpgrade(address newImplementation)
internal
override
Expand Down
Loading
Loading