-
Notifications
You must be signed in to change notification settings - Fork 396
feat(aggregation-mode): daily proofs limit #2198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a3e0aad
feat(aggregation-mode): daily proofs limit
maximopalopoli a59d4f3
remove unnecessary format conversion on error messages
maximopalopoli b5a966c
move the max proofs per day value to the config files
maximopalopoli 0a143ac
Fix: fetch the count instead of fetching all the receipts
maximopalopoli d1c88a2
rename the config attribute for the max daily proofs
maximopalopoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,6 +101,28 @@ impl BatcherServer { | |
| }; | ||
| let state = state.get_ref(); | ||
|
|
||
| // Checking if this address has submited more proofs than the ones allowed per day | ||
| const MAX_PROOFS_PER_DAY: usize = 4; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The max proofs per day should be on a config
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in b5a966c |
||
|
|
||
| let daily_tasks_by_address = match state | ||
| .db | ||
| .get_daily_tasks_by_address(&recovered_address) | ||
| .await | ||
| { | ||
| Ok(receipts) => receipts.len(), | ||
| Err(_) => { | ||
| return HttpResponse::InternalServerError() | ||
| .json(AppResponse::new_unsucessfull("Internal server error", 500)) | ||
| } | ||
| }; | ||
|
|
||
| if daily_tasks_by_address >= MAX_PROOFS_PER_DAY { | ||
| return HttpResponse::InternalServerError().json(AppResponse::new_unsucessfull( | ||
| "Request denied: Query limit exceeded.", | ||
| 400, | ||
| )); | ||
| } | ||
|
|
||
| let Ok(count) = state.db.count_tasks_by_address(&recovered_address).await else { | ||
| return HttpResponse::InternalServerError() | ||
| .json(AppResponse::new_unsucessfull("Internal server error", 500)); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should make a count instead of returning a list and applying a length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 0a143ac