-
Notifications
You must be signed in to change notification settings - Fork 0
SGA-13064: Query parsing failed due to casting to text(n) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
913cf0e
ab33d32
0d34152
21e9b28
d1dca11
180f294
8b7bdb3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,4 +90,9 @@ impl Dialect for DatabricksDialect { | |
| fn supports_optimize_table(&self) -> bool { | ||
| true | ||
| } | ||
|
|
||
| /// See <https://docs.databricks.com/aws/en/sql/language-manual/functions/bangsign> | ||
| fn supports_bang_not_operator(&self) -> bool { | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert this change it's not related to the issue
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this feedback in 8b7bdb3. Summary: Applied the review follow-up in commit |
||
| true | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -199,10 +199,15 @@ impl TestedDialects { | |
| /// Ensures that `sql` parses as a single [Statement], and that | ||
| /// re-serializing the parse result produces the same `sql` | ||
| /// string (is not modified after a serialization round-trip). | ||
| pub fn verified_stmt(&self, sql: &str) -> Statement { | ||
| pub fn verified_statement(&self, sql: &str) -> Statement { | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert this change, keep the original function name
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this feedback in 21e9b28. Summary: Applied the review feedback by reverting the helper API churn and restoring the Snowflake tests to the existing
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this feedback in d1dca11. Summary: Reverted the remaining unrelated review-follow-up change in src/test_utils.rs, restoring the doc comment text to match upstream and leaving the Snowflake
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this feedback in 180f294. Summary: Removed the unrelated baseline test from tests/sqlparser_snowflake.rs, leaving the
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this feedback in 8b7bdb3. Summary: Applied the review follow-up in commit |
||
| self.one_statement_parses_to(sql, sql) | ||
| } | ||
|
|
||
| /// Shorthand for [`TestedDialects::verified_statement`]. | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert this change
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this feedback in 21e9b28. Summary: Applied the review feedback by reverting the helper API churn and restoring the Snowflake tests to the existing
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this feedback in d1dca11. Summary: Reverted the remaining unrelated review-follow-up change in src/test_utils.rs, restoring the doc comment text to match upstream and leaving the Snowflake
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this feedback in 180f294. Summary: Removed the unrelated baseline test from tests/sqlparser_snowflake.rs, leaving the
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this feedback in 8b7bdb3. Summary: Applied the review follow-up in commit |
||
| pub fn verified_stmt(&self, sql: &str) -> Statement { | ||
| self.verified_statement(sql) | ||
| } | ||
|
|
||
| /// Ensures that `sql` parses as a single [Query], and that | ||
| /// re-serializing the parse result produces the same `sql` | ||
| /// string (is not modified after a serialization round-trip). | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.