Fix for XLML tests failing with jax nightly#242
Merged
Conversation
Collaborator
|
maxtdiffusion e2e started to be green today as 09/05.
https://c3aed121fd4247389a3ca4b9c5878779-dot-us-east4.composer.googleusercontent.com/dags/jax_ai_image_candidate_tpu_e2e/grid?tab=graph&dag_run_id=manual__2025-09-05T10%3A19%3A29.084042%2B00%3A00&task_id=maxdiffusion-jax-stable-stack-sdxl-stable-v5-8-1x-v5p-8
please checkout with latest version.
…On Fri, Sep 5, 2025 at 10:31 AM github-actions[bot] < ***@***.***> wrote:
*github-actions[bot]* left a comment (AI-Hypercomputer/maxdiffusion#242)
<#242 (comment)>
e2e testgrid:
https://8bcf50593faf4ea38060e236169827e5-dot-us-central1.composer.googleusercontent.com/dags/maxdiffusion_tpu_e2e/grid
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBKSJBM2F33UEIH2EP2QIL3RHCGXAVCNFSM6AAAAACFXZWPM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENJZGIZDGMJTGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
entrpn
approved these changes
Sep 8, 2025
susanbao
pushed a commit
that referenced
this pull request
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly XLML tests have been failing with this message:
jax._src.dtypes.InvalidInputException: Argument 'ShapeDtypeStruct(...)' of type <class 'jax._src.core.ShapeDtypeStruct'> is not a valid JAX type.These are the logs: https://paste.googleplex.com/4875429911199744
There is a call to x.unbox() within unbox_logicallypartioned_trainstate during the setup_initial_state. The code is doing sharding on an abstract representation of an array, which jax doesn't allow. The fix is to only do the unboxing on concrete arrays and not abstract arrays.
Link to successfull workload run after the change: https://c3aed121fd4247389a3ca4b9c5878779-dot-us-east4.composer.googleusercontent.com/dags/jax_ai_image_candidate_tpu_e2e/grid?tab=graph&dag_run_id=manual__2025-09-05T10%3A19%3A29.084042%2B00%3A00&task_id=maxdiffusion-jax-stable-stack-sdxl-stable-v5-8-1x-v5p-8