Skip to content

Fix for XLML tests failing with jax nightly #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
entrpn merged 1 commit into from
Sep 8, 2025
Merged

Fix for XLML tests failing with jax nightly #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/maxdiffusion/max_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,12 +359,11 @@ def get_abstract_state(model, tx, config, mesh, weights_init_fn, training=True):
state_mesh_shardings = nn.logical_to_mesh_sharding(state_logical_annotations, mesh, config.logical_axis_rules)

abstract_sharded_state = jax.jit(init_state_partial, in_shardings=None, out_shardings=state_mesh_shardings).eval_shape()
unboxed_sharded_abstract_state = unbox_logicallypartioned_trainstate(abstract_sharded_state)

# Initialization
with mesh, nn_partitioning.axis_rules(config.logical_axis_rules):
state_mesh_annotations = nn.logical_to_mesh(state_logical_annotations)
return unboxed_sharded_abstract_state, state_mesh_annotations, state_mesh_shardings
return abstract_sharded_state, state_mesh_annotations, state_mesh_shardings


def setup_initial_state(
Expand Down
Loading