Fixes for FLUX#258
Merged
coolkp merged 3 commits intoAI-Hypercomputer:mainfrom Oct 7, 2025
Merged
Conversation
coolkp
reviewed
Oct 2, 2025
| """ If TransformerEngine is available, this context manager will provide the library with MaxText-specific details needed for correcct operation. """ | ||
| try: | ||
| from transformer_engine.jax.sharding import global_shard_guard, MeshResource | ||
| # Inform TransformerEngine of MaxText's physical mesh resources. |
coolkp
reviewed
Oct 2, 2025
coolkp
reviewed
Oct 2, 2025
|
|
||
| if __name__ == "__main__": | ||
| app.run(main) | ||
| with transformer_engine_context(): |
Collaborator
There was a problem hiding this comment.
Is this needed for sdxl too?
Contributor
Author
There was a problem hiding this comment.
Yes it's needed for any model that uses TE to let TE know the physical mesh axes.
Collaborator
There was a problem hiding this comment.
Then can you add in the train_sdxl as well?
coolkp
previously approved these changes
Oct 6, 2025
coolkp
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix FLUX config and issues with the latest TE.