-
Notifications
You must be signed in to change notification settings - Fork 70
Fixes for FLUX #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for FLUX #258
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,7 @@ | |
|
|
||
| from maxdiffusion.train_utils import ( | ||
| validate_train_config, | ||
| transformer_engine_context, | ||
| ) | ||
|
|
||
|
|
||
|
|
@@ -39,6 +40,6 @@ def main(argv: Sequence[str]) -> None: | |
| max_logging.log(f"Found {jax.device_count()} devices.") | ||
| train(config) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| app.run(main) | ||
| with transformer_engine_context(): | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this needed for sdxl too?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes it's needed for any model that uses TE to let TE know the physical mesh axes.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then can you add in the train_sdxl as well? |
||
| app.run(main) | ||
Uh oh!
There was an error while loading. Please reload this page.