feat(secret-manager): add optional ttl field to createSecret function

[hivanalejandro]

Description

• Introduced the 'ttl' parameter in the Node.js sample for creating secrets.
• Ensured backward compatibility by handling cases where 'ttl' is undefined.

Fixes:

• b/384052815
• b/384942429

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test (see Testing)
• Lint pass: npm run lint (see Style)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[ghost]

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, authored by @hivanalejandro, aims to add an optional ttl (time-to-live) field to the createSecret function in the secret-manager Node.js sample. The intent is to allow users to specify a lifespan for their secrets.

Here's a breakdown of the changes:

• File Changed: secret-manager/createSecret.js
  • An optional ttl parameter has been added to the main function, allowing users to specify the secret's time-to-live in seconds (e.g., '900s' for 15 minutes).
  • The code now handles cases where ttl is undefined, ensuring backward compatibility.
  • The createSecret function is modified to include the ttl in the secret configuration if provided.

The changes are implemented cleanly and efficiently. The code is well-documented and easy to understand. Backward compatibility is maintained by handling the case where ttl is not provided. The addition of the ttl parameter enhances the functionality of the createSecret function, providing users with more control over their secrets.

I'll be providing a more detailed review soon.

---

And now, a little haiku to lighten the mood:

Secrets short or long,
Time to live, a new option,
Code flows smoothly on.

[ghost]

This pull request adds an optional TTL field to the createSecret function, which is a good improvement. The implementation looks correct and maintains backward compatibility. However, there are a few minor suggestions for improvement.

[briandorsey]

Overall looks good.

Could I ask you to also update the test (I think it's: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/4f660cdf6874bd4c3d5c2c9c1335caef2d20c8a3/secret-manager/test/secretmanager.test.js#L248C7-L248C23) to pass the new TTL parameter as well?

[hivanalejandro]

741ca18

Hi @briandorsey. The test has been updated to pass the new TTL parameter (741ca18)

[briandorsey]

LGTM, thanks for the detailed iteration work!