-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(secret-manager): add optional ttl field to createSecret function #3950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
briandorsey
merged 13 commits into
main
from
fix/optional-ttl-field-to-createSecret-function
Mar 13, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
841186b
feat(secret-manager): add optional ttl field to createSecret function
hivanalejandro d8abb66
fix linting errors
hivanalejandro 9bedf11
fix: update TTL format
hivanalejandro 9845093
fix: correct ttl parameter
hivanalejandro d6a6194
Merge branch 'main' into fix/optional-ttl-field-to-createSecret-function
hivanalejandro 741ca18
fix(secret-manager): Update unit test for createSecret.js
hivanalejandro 65a8797
Merge branch 'main' into fix/optional-ttl-field-to-createSecret-function
hivanalejandro 40d2240
Merge branch 'main' into fix/optional-ttl-field-to-createSecret-function
iennae e349295
Merge branch 'main' into fix/optional-ttl-field-to-createSecret-function
glasnt c115ac4
Merge branch 'main' into fix/optional-ttl-field-to-createSecret-function
hivanalejandro baa5097
fix(secret-manager): Add TTL support to secret creation with improved…
hivanalejandro 915bc81
Merge branch 'main' into fix/optional-ttl-field-to-createSecret-function
hivanalejandro 6b39c7b
Merge branch 'main' into fix/optional-ttl-field-to-createSecret-function
hivanalejandro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.