Typed service communication refactor#775
Open
Swofty-Developments wants to merge 21 commits intomasterfrom
Open
Typed service communication refactor#775Swofty-Developments wants to merge 21 commits intomasterfrom
Swofty-Developments wants to merge 21 commits intomasterfrom
Conversation
…nSerializer + records
…jects to JacksonSerializer + records
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Swofty-Developments
force-pushed
the
service-revamp
branch
from
01c07e7 to
9e936d0
Compare
…unishment type conversion
Swofty-Developments
force-pushed
the
service-revamp
branch
from
9e936d0 to
179fd6a
Compare
Owner
Author
|
@ArikSquad wouldn't mind a review |
Contributor
|
Seems like a great change |
ArikSquad
reviewed
Apr 19, 2026
Contributor
ArikSquad
left a comment
ArikSquad
left a comment
There was a problem hiding this comment.
it also could be beneficial to touch the party propagation system while doing these changes
| return new JacksonSerializer<>(AreFriendsResponse.class); | ||
| } | ||
|
|
||
| public record AreFriendsMessage(UUID player1, UUID player2) { |
Contributor
There was a problem hiding this comment.
nit: maybe player, and other? (not related to this PR but now that you are here)
| import org.junit.jupiter.api.Test; | ||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| class SanityTest { |
Contributor
There was a problem hiding this comment.
is this necessary at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.