Update permitted ARIA state or property for combobox role#2322
Merged
WilcoFiers merged 7 commits intodevelopfrom Aug 21, 2025
Merged
Update permitted ARIA state or property for combobox role#2322WilcoFiers merged 7 commits intodevelopfrom
WilcoFiers merged 7 commits intodevelopfrom
Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WilcoFiers
previously requested changes
May 1, 2025
Member
WilcoFiers
left a comment
There was a problem hiding this comment.
Minor nitpick. I also think we should add something to the background noting the change in ARIA 1.3.
Update the property value Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Collaborator
Author
|
@WilcoFiers Added a reference to ARIA 1.3 in the background section, and other changes you mentioned. ALso fixed some merge conflicts. |
WilcoFiers
reviewed
May 8, 2025
WilcoFiers
approved these changes
May 8, 2025
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
sage-putnam
approved these changes
May 8, 2025
adithyasai16
approved these changes
Jul 20, 2025
Collaborator
adithyasai16
left a comment
There was a problem hiding this comment.
The Code contains the changes of "aria-controls" to "aria-expanded" in the Pass example 6, 7 & 8. This is approved.
colabottles
approved these changes
Jul 24, 2025
carlosapaduarte
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<< Describe the changes >>
Per the latest ARIA spec, change the permitted ARIA state or property for "combobox" role from "aria-controls" to "aria-expanded" in the Pass example 6, 7 & 8.
Closes issue(s):
Need for Call for Review:
This will require a 1 week Call for Review
How to Review And Approve