Skip to content

Update permitted ARIA state or property for combobox role #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilcoFiers merged 7 commits into from
Aug 21, 2025
Merged

Update permitted ARIA state or property for combobox role #2322

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
90dc69d
update the rule for combobox role #rule-2311
shunguoy Apr 16, 2025
d0eba46
update the text #rule-2311
shunguoy Apr 16, 2025
6e61093
Update aria-state-or-property-permitted-5c01ea.md
shunguoy Apr 16, 2025
0e3efb5
Update _rules/aria-state-or-property-permitted-5c01ea.md
shunguoy May 1, 2025
b6139e5
update the required state and properties rule #rule-2311
shunguoy May 7, 2025
af583d9
Merge branch 'develop' into rule-2311
shunguoy May 7, 2025
da1650e
Update _rules/aria-state-or-property-permitted-5c01ea.md
shunguoy May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions _rules/aria-state-or-property-permitted-5c01ea.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,26 +126,26 @@ The `aria-checked` [state][] is [required][] for the [semantic][semantic role] `

#### Passed Example 6

The `aria-controls` [property][] is [required][] for the [semantic][semantic role] `combobox`.
The `aria-expanded` [property][] is [required][] for the [semantic][semantic role] `combobox`.

```html
<div role="combobox" aria-controls="id1" aria-expanded="false">My combobox</div>
```

#### Passed Example 7

The `aria-controls` [property][] is [required][] for the [semantic][semantic role] `combobox`. [WAI-ARIA states and properties][wai-aria state or property] with empty value are still applicable to this rule.
The `aria-expanded` [property][] is [required][] for the [semantic][semantic role] `combobox`.

```html
<div role="combobox" aria-expanded="false" aria-controls>My combobox</div>
<div role="combobox" aria-expanded="true" aria-controls="id1">My combobox</div>
Comment thread
shunguoy marked this conversation as resolved.
Outdated
```

#### Passed Example 8

The `aria-controls` [property][] is [required][] for the [semantic][semantic role] `combobox`. [WAI-ARIA states and properties][wai-aria state or property] with empty value (specified as an empty string) are still applicable to this rule.
The `aria-expanded` [property][] is [required][] for the [semantic][semantic role] `combobox`. [WAI-ARIA states and properties][wai-aria state or property] with `undefined` value are still applicable to this rule.

```html
<div role="combobox" aria-expanded="false" aria-controls="">My combobox</div>
<div role="combobox" aria-expanded="undefined" aria-controls="id1">My combobox</div>
```

#### Passed Example 9
Expand Down Expand Up @@ -181,8 +181,13 @@ This `div` element has an [explicit role][] of `switch`; the `aria-required` [pr
```html
<div role="switch" aria-checked="false" tabindex="0" aria-required="true">
<span class="label">Notifications</span>
<span class="switch" style="position: relative; display: inline-block; top: 6px; border: 2px solid black; border-radius: 12px; height: 20px; width: 40px;">
<span style="position: absolute; top: 2px; left: 2px; display: inline-block; border: 2px solid black; border-radius: 8px; height: 12px; width: 12px; background: black;"></span>
<span
class="switch"
style="position: relative; display: inline-block; top: 6px; border: 2px solid black; border-radius: 12px; height: 20px; width: 40px;"
>
<span
style="position: absolute; top: 2px; left: 2px; display: inline-block; border: 2px solid black; border-radius: 8px; height: 12px; width: 12px; background: black;"
></span>
</span>
<span class="on" aria-hidden="true" style="display: none;">On</span>
<span class="off" aria-hidden="true">Off</span>
Expand Down
Loading