Skip to content

[4e8ab6] Fix aria mapping on the "Element with role attribute has required states and properties" rule#2328

Merged
WilcoFiers merged 2 commits intoact-rules:developfrom
zlayaAvocado:role-required-fix-aria-mapping
May 15, 2025
Merged

[4e8ab6] Fix aria mapping on the "Element with role attribute has required states and properties" rule#2328
WilcoFiers merged 2 commits intoact-rules:developfrom
zlayaAvocado:role-required-fix-aria-mapping

Conversation

@zlayaAvocado
Copy link
Copy Markdown
Collaborator

Fix aria mapping on the "Element with role attribute has required states and properties" rule since the aria title is required. Test will be added in a separate PR since the fix is urgent.

Closes issue(s):

Need for Call for Review:
This will not require a Call for Review: Accessibility Requirements Mapping fix

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@zlayaAvocado zlayaAvocado self-assigned this May 12, 2025
@zlayaAvocado zlayaAvocado added the Editorial For editorial changes that does not change the meaning of a rule or Glossary term label May 12, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit b3c8851
🔍 Latest deploy log https://app.netlify.com/sites/act-rules/deploys/6822662aa9a6b10008366eb5
😎 Deploy Preview https://deploy-preview-2328--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zlayaAvocado zlayaAvocado marked this pull request as ready for review May 12, 2025 21:26
@zlayaAvocado zlayaAvocado requested a review from WilcoFiers May 12, 2025 21:26
@zlayaAvocado zlayaAvocado changed the title Fix aria mapping on the "Element with role attribute has required states and properties" rule [4e8ab6] Fix aria mapping on the "Element with role attribute has required states and properties" rule May 12, 2025
@WilcoFiers WilcoFiers merged commit bc308f0 into act-rules:develop May 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Editorial For editorial changes that does not change the meaning of a rule or Glossary term

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[4e8ab6] "undefined" accessibility requirement

5 participants