Change 'test cases' to 'examples' as required by ACT Rules Format 1.1 by daniel-montalvo · Pull Request #2352 · act-rules/act-rules.github.io

daniel-montalvo · 2025-09-16T11:56:58Z

The format now says that the test cases should be named examples, and it has a MUST on it, so we should do this before attempting to transition to REC.

Closes issue(s):

closes Not all rules "Test cases" have been renamed to "examples" w3c/wcag-act#609

Need for Call for Review:
This will require a 1-week call for review (changes the name of one of the key sections of our rules).

Pull Request Etiquette

When creating PR:

Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

Add yourself (and co-authors) as "Assignees" for PR.
Add label to indicate if it's a Rule, Definition or Chore.
Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

netlify · 2025-09-16T11:57:04Z

✅ Deploy Preview for act-rules ready!

Name	Link
🔨 Latest commit	`e673405`
🔍 Latest deploy log	https://app.netlify.com/projects/act-rules/deploys/68debf5c7f49d80008b33f33
😎 Deploy Preview	https://deploy-preview-2352--act-rules.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

kengdoj

I left some suggestions. Some are changes to path which I'm not sure of so please review.

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

@kengdoj

Thanks for picking these ones up @kengdoj

WilcoFiers

These changes look good to me, but I think we probably should do at least a 1-week call for review for this.

The review period has been updated.

zlayaAvocado · 2025-10-02T14:35:24Z

@@ -23,7 +23,7 @@ describeRule('testcase has heading', ({ filename, markdownAST }) => {
 	 * Check if filename has `id` as a part of the name
 	 */
 	test('each testcase has a heading', () => {


are we also changing testcase (with no space) to example?

@daniel-montalvo can you look at this. Discussed on the call, we can do this in a separate PR too if you prefer.

@WilcoFiers @zlayaAvocado I miss this one. Yes, I will update this os that tecase is also changed to example

zlayaAvocado

just one non blocking comment

Changes 'test cases' to 'examples' as required by ACT Rules Format 1.1

117965f

daniel-montalvo changed the title ~~Changes 'test cases' to 'examples' as required by ACT Rules Format 1.1~~ Change 'test cases' to 'examples' as required by ACT Rules Format 1.1 Sep 16, 2025

daniel-montalvo self-assigned this Sep 16, 2025

daniel-montalvo requested review from HelenBurge, WilcoFiers, carlosapaduarte and kengdoj September 16, 2025 12:00

daniel-montalvo marked this pull request as draft September 16, 2025 12:29

daniel-montalvo added 2 commits September 16, 2025 14:46

Tests +less obvious occurrences

6ef40f7

Fix const value typo

c47852b

daniel-montalvo marked this pull request as ready for review September 16, 2025 13:25

daniel-montalvo mentioned this pull request Sep 16, 2025

Change 'test cases' to 'examples' act-rules/act-tools#41

Merged

kengdoj reviewed Sep 23, 2025

View reviewed changes

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated

Update .github/PULL_REQUEST_TEMPLATE.md

2828aaf

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

daniel-montalvo requested a review from kengdoj September 23, 2025 13:53

kengdoj previously requested changes Sep 23, 2025

View reviewed changes

daniel-montalvo and others added 10 commits September 23, 2025 17:38

Update .github/ISSUE_TEMPLATE/ACCESSIBILITY_SUPPORT.md

59ecb2d

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update _rules/__tests__/example-has-heading.js

f9f193b

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update pages/design/rule-design.md

6a7c1f2

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update pages/design/rule-design.md

e5c5c23

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update pages/implementations/earl-reports.md

fa4ffba

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update pages/implementations/earl-reports.md

3c82a3a

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update pages/implementations/examples.md

219bf68

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update pages/implementations/examples.md

d58e64e

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update pages/implementations/mapping.md

5231261

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update pages/implementations/reporting.md

f45da26

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

daniel-montalvo requested a review from kengdoj September 23, 2025 15:58

WilcoFiers previously requested changes Sep 24, 2025

View reviewed changes

kengdoj reviewed Sep 24, 2025

View reviewed changes

Comment thread pages/implementations/overview.md Outdated

Apply suggestion from @kengdoj

3bffeb0

daniel-montalvo added General for all rules Review Call 1 week Call for review for small changes labels Sep 24, 2025

daniel-montalvo requested review from WilcoFiers and kengdoj September 24, 2025 14:12

carlosapaduarte approved these changes Sep 29, 2025

View reviewed changes

colabottles approved these changes Sep 29, 2025

View reviewed changes

zlayaAvocado reviewed Oct 2, 2025

View reviewed changes

zlayaAvocado approved these changes Oct 2, 2025

View reviewed changes

sage-putnam approved these changes Oct 2, 2025

View reviewed changes

More missing occurrences

e673405

daniel-montalvo merged commit 4d39215 into develop Oct 6, 2025
6 checks passed

daniel-montalvo deleted the change-test-cases-to-examples branch October 6, 2025 16:30

Conversation

daniel-montalvo commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Etiquette

When creating PR:

After creating PR:

When merging a PR:

How to Review And Approve

Uh oh!

netlify bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for act-rules ready!

Uh oh!

Uh oh!

kengdoj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WilcoFiers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zlayaAvocado Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

WilcoFiers Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-montalvo Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

zlayaAvocado left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

daniel-montalvo commented Sep 16, 2025 •

edited

Loading

netlify bot commented Sep 16, 2025 •

edited

Loading