-
Notifications
You must be signed in to change notification settings - Fork 83
Change 'test cases' to 'examples' as required by ACT Rules Format 1.1 #2352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
117965f
6ef40f7
c47852b
2828aaf
59ecb2d
f9f193b
6a7c1f2
e5c5c23
fa4ffba
3c82a3a
219bf68
d58e64e
5231261
f45da26
3bffeb0
e673405
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ const getMarkdownAstNodesOfType = require('../../utils/get-markdown-ast-nodes-of | |
|
|
||
| describeRule('testcase has heading', ({ filename, markdownAST }) => { | ||
| /** | ||
| * get all headings of test case examples (eg: #### Failed Example 1) | ||
| * get all headings of example examples (eg: #### Failed Example 1) | ||
|
daniel-montalvo marked this conversation as resolved.
Outdated
|
||
| */ | ||
| const testcaseHeadings = getMarkdownAstNodesOfType(markdownAST, 'heading') | ||
| .filter(({ depth, children }) => { | ||
|
|
@@ -23,7 +23,7 @@ describeRule('testcase has heading', ({ filename, markdownAST }) => { | |
| * Check if filename has `id` as a part of the name | ||
| */ | ||
| test('each testcase has a heading', () => { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are we also changing
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @daniel-montalvo can you look at this. Discussed on the call, we can do this in a separate PR too if you prefer.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @WilcoFiers @zlayaAvocado I miss this one. Yes, I will update this os that tecase is also changed to example |
||
| const msg = `Not all test cases have headings in ${filename}.` | ||
| const msg = `Not all examples have headings in ${filename}.` | ||
| expect(testcaseHeadings.length, msg).toBe(testcaseCodeSnippets.length) | ||
| }) | ||
| }) | ||
Uh oh!
There was an error while loading. Please reload this page.