Link AIP-157 from AIP-161#1503
Merged
noahdietz merged 3 commits intoaip-dev:masterfrom Mar 28, 2025
Merged
Conversation
Point out the alternative to the deprecated `read_mask` field.
noahdietz
reviewed
Mar 28, 2025
Collaborator
noahdietz
left a comment
noahdietz
left a comment
There was a problem hiding this comment.
Thanks! Just one comment
|
|
||
| **Warning:** Read masks as a single field on the request message, for | ||
| example: `google.protobuf.FieldMask read_mask` are **DEPRECATED**. | ||
| example: `google.protobuf.FieldMask read_mask` are **DEPRECATED**. Instead, see AIP-157. |
Collaborator
There was a problem hiding this comment.
Suggested change
| example: `google.protobuf.FieldMask read_mask` are **DEPRECATED**. Instead, see AIP-157. | |
| example: `google.protobuf.FieldMask read_mask` are **DEPRECATED**. Instead, see | |
| [AIP-157][]. |
Line wrap on 80 columns and make AIP-157 a reference (site-generator should auto link to the AIP without an explicit markdown ref definition)
Contributor
Author
There was a problem hiding this comment.
Applied -- thanks! It looked from the footer like it even auto links raw mentions, but this is clearer.
Collaborator
There was a problem hiding this comment.
You know what, I just looked back at the site-generator code, and you are right, it hotlinks when not referenced. My apologies! We can switch back to simple AIP-157
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
noahdietz
reviewed
Mar 28, 2025
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
noahdietz
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point out the alternative to the deprecated
read_maskfield.