Skip to content

Link AIP-157 from AIP-161 #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noahdietz merged 3 commits into from
Mar 28, 2025
Merged

Link AIP-157 from AIP-161 #1503

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8dfca7
Link AIP-157 from AIP-161
icmdaf Mar 28, 2025
4267898
Update aip/general/0161.md
icmdaf Mar 28, 2025
981902e
Update aip/general/0161.md
icmdaf Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aip/general/0161.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ common on Update requests (AIP-134).
Field masks **must** always be relative to the resource:

**Warning:** Read masks as a single field on the request message, for
example: `google.protobuf.FieldMask read_mask` are **DEPRECATED**.
example: `google.protobuf.FieldMask read_mask` are **DEPRECATED**. Instead, see AIP-157.
Copy link
Copy Markdown
Collaborator

@noahdietz noahdietz Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
example: `google.protobuf.FieldMask read_mask` are **DEPRECATED**. Instead, see AIP-157.
example: `google.protobuf.FieldMask read_mask` are **DEPRECATED**. Instead, see
[AIP-157][].

Line wrap on 80 columns and make AIP-157 a reference (site-generator should auto link to the AIP without an explicit markdown ref definition)

Copy link
Copy Markdown
Contributor Author

@icmdaf icmdaf Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied -- thanks! It looked from the footer like it even auto links raw mentions, but this is clearer.

Copy link
Copy Markdown
Collaborator

@noahdietz noahdietz Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what, I just looked back at the site-generator code, and you are right, it hotlinks when not referenced. My apologies! We can switch back to simple AIP-157


```proto
message UpdateBookRequest {
Expand Down