Skip to content

Snowflake: Support IDENTIFIER for GRANT ROLE#1957

Merged
iffyio merged 1 commit intoapache:mainfrom
yoavcloud:sf_grant_role_identifier
Jul 23, 2025
Merged

Snowflake: Support IDENTIFIER for GRANT ROLE#1957
iffyio merged 1 commit intoapache:mainfrom
yoavcloud:sf_grant_role_identifier

Conversation

@yoavcloud
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavcloud double checking the intent is to add ObjectName support rather than Identifier as the MR description mentions?

Comment thread src/ast/mod.rs
@yoavcloud yoavcloud requested a review from iffyio July 21, 2025 13:52
Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yoavcloud!
cc @alamb

@iffyio iffyio merged commit 7558d35 into apache:main Jul 23, 2025
10 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants