Reserve LuceneDev6001-6003 and add initial entries for string/span/char analyzer rules#13
Conversation
…ar analyzer rules
…ar analyzer rules
NightOwl888
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I am not an expert on writing code analyzers, but I thought this was going to require more diagnostic IDs. I will give you the benefit of the doubt, though. Having fewer IDs makes reviewing them easier. If it turns out we need more, we can just reserve more later.
Please see my inline comment - just one minor thing to fix before this can be merged to suppress the warnings about the table format in AnalyzerReleases.Unshipped.md.
|
As long as the message of the diagnostic is the same, and the code fix if applicable, you can have as much logic in the diagnostic (and code fix) as you want. So it's fine to have an analyzer that handles lots of different sub-cases. Note though that we do not want to update the Unshipped file with analyzers that do not exist yet. The only thing needed to do to reserve an ID is to update the ranges file at this time. Typically you will update the Unshipped file with the analyzers that are included with your PR. |
This PR reserves diagnostic IDs 6001-6003 and adds corresponding entries in AnalyzerReleases.Unshipped.md for the new analyzers:
These changes are in preparation for implementing the analyzers in the next PR.