Skip to content

Reserve LuceneDev6001-6003 and add initial entries for string/span/char analyzer rules #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NightOwl888 merged 3 commits into from
Oct 17, 2025
Merged

Reserve LuceneDev6001-6003 and add initial entries for string/span/char analyzer rules #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37e7a05
Reserve LuceneDev6001-6003 and add initial entries for string/span/ch…
NehanPathan Oct 17, 2025
6e47421
Reserve LuceneDev6001-6003 and add initial entries for string/span/ch…
NehanPathan Oct 17, 2025
5e42526
fix: correct table format in AnalyzerReleases.Unshipped.md to resolve…
NehanPathan Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions DiagnosticCategoryAndIdRanges.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
# 4. Your rule ID is now reserved and can be used in your PR.
#
# In the event of conflict in step 3, make sure you discard your changes, pull latest, and try again.
# DO NOT remove ID ranges already defined or merge this file in git.
# DO NOT remove ID ranges already defined or merge this file in git.
#
Design: LuceneDev1000-LuceneDev1008
Globalization:
Mobility:
Performance:
Security:
Usage: LuceneDev6000
Usage: LuceneDev6000-LuceneDev6003
Naming:
Interoperability:
Maintainability:
Maintainability:
Reliability:
Documentation:
13 changes: 8 additions & 5 deletions src/Lucene.Net.CodeAnalysis.Dev/AnalyzerReleases.Unshipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
### New Rules

Rule ID | Category | Severity | Notes
---------------|----------|----------|-----------------------------------------------------------------------------------------------------------------------------------------------------------
LuceneDev1007 | Design | Warning | Generic Dictionary<TKey, TValue> indexer should not be used to retrieve values because it may throw KeyNotFoundException (value type value)
LuceneDev1008 | Design | Warning | Generic Dictionary<TKey, TValue> indexer should not be used to retrieve values because it may throw KeyNotFoundException (reference type value)
LuceneDev6000 | Usage | Info | IDictionary indexer may be used to retrieve values, but must be checked for null before using the value
Rule ID | Category | Severity | Notes
--------------|----------|----------|-----------------------------------------------------------------------------------------------------------------------------------------------------------
LuceneDev1007 | Design | Warning | Generic Dictionary<TKey, TValue> indexer should not be used to retrieve values because it may throw KeyNotFoundException (value type value)
LuceneDev1008 | Design | Warning | Generic Dictionary<TKey, TValue> indexer should not be used to retrieve values because it may throw KeyNotFoundException (reference type value)
LuceneDev6000 | Usage | Info | IDictionary indexer may be used to retrieve values, but must be checked for null before using the value
LuceneDev6001 | Usage | Error | String overloads of StartsWith/EndsWith/IndexOf/LastIndexOf must be called with StringComparison.Ordinal or StringComparison.OrdinalIgnoreCase
LuceneDev6002 | Usage | Warning | Span overloads of StartsWith/EndsWith/IndexOf/LastIndexOf should not pass non-Ordinal StringComparison
LuceneDev6003 | Usage | Info | Single-character string arguments should use the char overload of StartsWith/EndsWith/IndexOf/LastIndexOf instead of a string