[ISSUE #9235] fix: response codes do not match#9236
Closed
3424672656 wants to merge 3 commits intoapache:developfrom
Closed
[ISSUE #9235] fix: response codes do not match#92363424672656 wants to merge 3 commits intoapache:developfrom
3424672656 wants to merge 3 commits intoapache:developfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9236 +/- ##
=============================================
- Coverage 48.02% 48.02% -0.01%
+ Complexity 12095 12094 -1
=============================================
Files 1322 1322
Lines 93094 93103 +9
Branches 11933 11935 +2
=============================================
+ Hits 44709 44710 +1
- Misses 42847 42856 +9
+ Partials 5538 5537 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RongtongJin
reviewed
Mar 12, 2025
|
|
||
| response.setCode(ResponseCode.CONSUMER_NOT_ONLINE); | ||
| response.setRemark("the consumer group[" + requestHeader.getConsumerGroup() + "] not online"); | ||
| response.setCode(ResponseCode.SUBSCRIPTION_GROUP_NOT_EXIST); |
Contributor
There was a problem hiding this comment.
这种情况下有可能是CONSUMER_NOT_ONLINE，也有可能是SUBSCRIPTION_GROUP_NOT_EXIST
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9235
Brief Description
How Did You Test This Change?