Skip to content

[ISSUE #9235] fix: response codes do not match #9236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3424672656 wants to merge 3 commits into from
Closed

[ISSUE #9235] fix: response codes do not match #9236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03239c7
fix: Response codes do not match
Mar 11, 2025
fc2e86e
fix: Response codes do not match
Mar 12, 2025
d19169f
fix test
Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1855,6 +1855,12 @@ private RemotingCommand getConsumerConnectionList(ChannelHandlerContext ctx,
final GetConsumerConnectionListRequestHeader requestHeader =
(GetConsumerConnectionListRequestHeader) request.decodeCommandCustomHeader(GetConsumerConnectionListRequestHeader.class);

if (!this.brokerController.getSubscriptionGroupManager().containsSubscriptionGroup(requestHeader.getConsumerGroup())) {
response.setCode(ResponseCode.SUBSCRIPTION_GROUP_NOT_EXIST);
response.setRemark("the consumer group[" + requestHeader.getConsumerGroup() + "] not exist");
return response;
}

ConsumerGroupInfo consumerGroupInfo =
this.brokerController.getConsumerManager().getConsumerGroupInfo(requestHeader.getConsumerGroup());
if (consumerGroupInfo != null) {
Expand Down
4 changes: 4 additions & 0 deletions broker/src/test/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.apache.rocketmq.broker.schedule.ScheduleMessageService;
import org.apache.rocketmq.broker.config.v1.RocksDBSubscriptionGroupManager;
import org.apache.rocketmq.broker.config.v1.RocksDBTopicConfigManager;
import org.apache.rocketmq.broker.subscription.SubscriptionGroupManager;
import org.apache.rocketmq.broker.topic.TopicConfigManager;
import org.apache.rocketmq.common.BoundaryType;
import org.apache.rocketmq.common.BrokerConfig;
Expand Down Expand Up @@ -681,7 +682,10 @@ public void testGetConsumerConnectionList() throws RemotingCommandException {
RemotingCommand request = RemotingCommand.createRequestCommand(RequestCode.GET_CONSUMER_CONNECTION_LIST, null);
request.addExtField("consumerGroup", "GID-group-test");
consumerManager = mock(ConsumerManager.class);
SubscriptionGroupManager subscriptionGroupManager = mock(SubscriptionGroupManager.class);
when(brokerController.getConsumerManager()).thenReturn(consumerManager);
when(brokerController.getSubscriptionGroupManager()).thenReturn(subscriptionGroupManager);
when(subscriptionGroupManager.containsSubscriptionGroup(anyString())).thenReturn(true);
ConsumerGroupInfo consumerGroupInfo = new ConsumerGroupInfo("GID-group-test", ConsumeType.CONSUME_ACTIVELY, MessageModel.CLUSTERING, ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET);
when(consumerManager.getConsumerGroupInfo(anyString())).thenReturn(consumerGroupInfo);
RemotingCommand response = adminBrokerProcessor.processRequest(handlerContext, request);
Expand Down
Loading