[ISSUE #9539] Fix compare policy entry logic in ACL 2.0#9540
Merged
lizhimins merged 1 commit intoapache:developfrom Jul 14, 2025
Merged
[ISSUE #9539] Fix compare policy entry logic in ACL 2.0#9540lizhimins merged 1 commit intoapache:developfrom
lizhimins merged 1 commit intoapache:developfrom
Conversation
Member
lizhimins
reviewed
Jul 11, 2025
| .filter(entry -> entry.isMatchAction(context.getActions())) | ||
| .filter(entry -> entry.isMatchEnvironment(Environment.of(context.getSourceIp()))) | ||
| .collect(Collectors.toList()); | ||
| .filter(entry -> entry.isMatchResource(context.getResource())) |
Member
There was a problem hiding this comment.
Import checkstyle from project
1782935682
force-pushed
the
bugfix/fix_acl_compare_policy
branch
from
cdd61e5 to
347d25c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9540 +/- ##
=============================================
- Coverage 48.01% 47.95% -0.06%
+ Complexity 12035 12022 -13
=============================================
Files 1312 1312
Lines 92694 92694
Branches 11855 11855
=============================================
- Hits 44504 44455 -49
- Misses 42675 42726 +51
+ Partials 5515 5513 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhimins
approved these changes
Jul 14, 2025
lizhimins
changed the title
hechen0
pushed a commit
to hechen0/rocketmq
that referenced
this pull request
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9539
Brief Description
How Did You Test This Change?