fix: prevent reserved variable names in tests#785
Merged
Conversation
9ad9168 to
f166467
Compare
bshaffer
commented
Oct 23, 2025
| // Mock request | ||
| $aString = 'aString-929604177'; | ||
| $partOfRequestA = []; | ||
| $requestStatus = 892481550; |
1 task
Hectorhammett
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See googleapis/google-cloud-php#8683
Tests are failing with the following error:

This is because in one of the generated tests, the
$statuslocal variable in the test is being overwritten with a variable named$statusthat is used to populate a required field in the request:I've fixed this by passing an array of
$reservedNamesto the code which generates this, and prefixing those names withrequest_before they're converted to camelcased. This will result in the name being$requestStatusin this case.