chore(tests): [AdsAdManager] avoid variable name conflict#8683
Merged
chore(tests): [AdsAdManager] avoid variable name conflict#8683
Conversation
trusted-contributions-gcf
Bot
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
trusted-contributions-gcf
Bot
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
Contributor
|
This is currently blocked by googleapis/gapic-generator-php#785, which will fix the failing tests |
gcf-owl-bot
Bot
changed the title
trusted-contributions-gcf
Bot
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
trusted-contributions-gcf
Bot
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
Contributor
Author
|
Owl bot is regenerating pull request 8683... |
PiperOrigin-RevId: 824648432 Source-Link: googleapis/googleapis@7a87bf0 Source-Link: googleapis/googleapis-gen@6d65fd3 Copy-Tag: eyJwIjoiQWRzQWRNYW5hZ2VyLy5Pd2xCb3QueWFtbCIsImgiOiI2ZDY1ZmQzMWRmMzRiODFiYzAyNzMwMjYwN2IyYzk2OWM4NDVjZDE4In0= feat: Added Application resource feat: Added AudienceSegment resource feat: Added Browser resource feat: Added BrowserLanguage resource feat: Added CmsMetadataKey resource feat: Added CmsMetadataValue resource feat: Added methods for reading and writing Contact resources feat: Added DeviceCapability resource feat: Added DeviceManufacturer resource feat: Added MobileCarrier resource feat: Added MobileDevice resource feat: Added MobileDeviceSubmodel resource feat: Added additional Report dimensions and metrics feat: Added Content resource feat: Added ContentBundle resource feat: Added ContentLabel resource feat: Added CreativeTemplate resource feat: Added Team resource feat!: Added required field `displayName` to Team feat: Added Site resource feat: Added AdReviewCenterAd methods fix!: Made AdUnitSize fields proto3 optional fix!: Made Label fields proto3 optional fix!: Made Contact fields proto3 optional feat!: Added required fields `displayName` and `company` to Contact fix!: Made Company fields proto3 optional fix!: Moved multiple Report messages and submessages fix!: Renamed ReportDefinition.Dimensions PROGRAMMATIC_BUYER_ID and PROGRAMMATIC_BUYER_NAME to DEAL_BUYER_ID and DEAL_BUYER_NAME fix!: Renamed ReportDefinition.Dimension AD_SERVER_UNFILTERED_IMPRESSIONS to AD_SERVER_UNFILTERED_DOWNLOADED_IMPRESSIONS docs: Clarified pagination defaults for List methods PiperOrigin-RevId: 822617305 Source-Link: googleapis/googleapis@1615c51 Source-Link: googleapis/googleapis-gen@359756d Copy-Tag: eyJwIjoiQWRzQWRNYW5hZ2VyLy5Pd2xCb3QueWFtbCIsImgiOiIzNTk3NTZkOGU3MmE3NjA3ODUxNGI0YzAyMjQxZGQ3NWRjYzFlOWU3In0=
gcf-owl-bot
Bot
force-pushed
the
owl-bot-copy-AdsAdManager
branch
from
afb9497 to
f6f5da0
Compare
trusted-contributions-gcf
Bot
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
trusted-contributions-gcf
Bot
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
bshaffer
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 824648432
Source-Link: googleapis/googleapis@7a87bf0
Source-Link: https://github.com/googleapis/googleapis-gen/commit/6d65fd31df34b81bc027302607b2c969c845cd18
Copy-Tag: eyJwIjoiQWRzQWRNYW5hZ2VyLy5Pd2xCb3QueWFtbCIsImgiOiI2ZDY1ZmQzMWRmMzRiODFiYzAyNzMwMjYwN2IyYzk2OWM4NDVjZDE4In0=
feat: Added Application resource
feat: Added AudienceSegment resource
feat: Added Browser resource
feat: Added BrowserLanguage resource
feat: Added CmsMetadataKey resource
feat: Added CmsMetadataValue resource
feat: Added methods for reading and writing Contact resources
feat: Added DeviceCapability resource
feat: Added DeviceManufacturer resource
feat: Added MobileCarrier resource
feat: Added MobileDevice resource
feat: Added MobileDeviceSubmodel resource
feat: Added additional Report dimensions and metrics
feat: Added Content resource
feat: Added ContentBundle resource
feat: Added ContentLabel resource
feat: Added CreativeTemplate resource
feat: Added Team resource
feat!: Added required field
displayNameto Teamfeat: Added Site resource
feat: Added AdReviewCenterAd methods
fix!: Made AdUnitSize fields proto3 optional
fix!: Made Label fields proto3 optional
fix!: Made Contact fields proto3 optional
feat!: Added required fields
displayNameandcompanyto Contactfix!: Made Company fields proto3 optional
fix!: Moved multiple Report messages and submessages
fix!: Renamed ReportDefinition.Dimensions PROGRAMMATIC_BUYER_ID and PROGRAMMATIC_BUYER_NAME to DEAL_BUYER_ID and DEAL_BUYER_NAME
fix!: Renamed ReportDefinition.Dimension AD_SERVER_UNFILTERED_IMPRESSIONS to AD_SERVER_UNFILTERED_DOWNLOADED_IMPRESSIONS
docs: Clarified pagination defaults for List methods
PiperOrigin-RevId: 822617305
Source-Link: googleapis/googleapis@1615c51
Source-Link: https://github.com/googleapis/googleapis-gen/commit/359756d8e72a76078514b4c02241dd75dcc1e9e7
Copy-Tag: eyJwIjoiQWRzQWRNYW5hZ2VyLy5Pd2xCb3QueWFtbCIsImgiOiIzNTk3NTZkOGU3MmE3NjA3ODUxNGI0YzAyMjQxZGQ3NWRjYzFlOWU3In0=
BREAKING_CHANGE_REASON=this library is in preview and the AdManager API is in beta