Closed
Conversation
bshaffer
added
next release
bshaffer
force-pushed
the
spanner-v2-refactor
branch
2 times, most recently
from
c2bb1c3 to
eae013d
Compare
bshaffer
force-pushed
the
spanner-multiplexed-sessions
branch
2 times, most recently
from
aff0e6f to
a7a0397
Compare
bshaffer
force-pushed
the
spanner-multiplexed-sessions
branch
from
a7a0397 to
60b6801
Compare
| require __DIR__ . '/../../../../vendor/autoload.php'; | ||
| } | ||
|
|
||
| BypassFinals::enable(); |
Collaborator
There was a problem hiding this comment.
Was comment to move this to a bootstrap file, but is this here because of this being related to a locking mechanism? Or we can move it to a bootstrap file?
Contributor
Author
There was a problem hiding this comment.
This is here because it is run separately, outside of PHP, and so doesn't bootstrap. We could have it manually include bootstrap.php, but I think it makes more sense for it to just enable BypassFinals itself
Collaborator
There was a problem hiding this comment.
Makes sense, +1 on keeping it here for simplicity. Don't think it looks bad or anything.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #7841
TODO