chore: use synthtool with no-install nox format#15562
Conversation
Summary of ChangesHello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a maintenance update by changing the specific Git commit hash for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the pinned commit for synthtool in the generator's Dockerfile. My review includes a suggestion to improve the efficiency of fetching this dependency by using a source archive instead of a full git clone, which will result in smaller and faster Docker builds.
| RUN git clone https://github.com/googleapis/synthtool.git synthtool && \ | ||
| cd synthtool && \ | ||
| git checkout 5dc7e990bb38ef8bc3d71cae6304e74d3037b9ef | ||
| git checkout afd7725f32d522a95e964884e0fba6d0d6b4cb6a |
There was a problem hiding this comment.
For better efficiency and smaller Docker image layers, consider downloading a source archive of the specific commit instead of cloning the entire repository history. git clone can be slow and consume significant disk space, especially for repositories with a long history. Using curl to download a .tar.gz archive is much faster and results in a smaller layer.
RUN curl -L https://github.com/googleapis/synthtool/archive/afd7725f32d522a95e964884e0fba6d0d6b4cb6a.tar.gz | tar -xz && \
mv synthtool-afd7725f32d522a95e964884e0fba6d0d6b4cb6a synthtool
use synthtool with no-install nox format