Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request skips the mypy check for four packages that do not have a py.typed file, implemented consistently across the modified noxfile.py files as a temporary measure. No obvious security vulnerabilities such as injection or hardcoded secrets were identified. A minor improvement has been suggested for the TODO comment in each noxfile.py file to make it more specific about re-enabling mypy.
| """Run the type checker.""" | ||
|
|
||
| # TODO(https://github.com/googleapis/google-cloud-python/issues/13362): | ||
| # Enable mypy once this bug is fixed. |
There was a problem hiding this comment.
The comment 'Enable mypy once this bug is fixed' is a bit vague. It would be clearer to state what needs to be done to enable mypy for this package. Consider rephrasing to clarify that a py.typed file is needed.
| # Enable mypy once this bug is fixed. | |
| # Enable mypy once this package has a py.typed file. |
| """Run the type checker.""" | ||
|
|
||
| # TODO(https://github.com/googleapis/google-cloud-python/issues/13362): | ||
| # Enable mypy once this bug is fixed. |
There was a problem hiding this comment.
The comment 'Enable mypy once this bug is fixed' is a bit vague. It would be clearer to state what needs to be done to enable mypy for this package. Consider rephrasing to clarify that a py.typed file is needed.
| # Enable mypy once this bug is fixed. | |
| # Enable mypy once this package has a py.typed file. |
| """Run the type checker.""" | ||
|
|
||
| # TODO(https://github.com/googleapis/google-cloud-python/issues/13362): | ||
| # Enable mypy once this bug is fixed. |
There was a problem hiding this comment.
The comment 'Enable mypy once this bug is fixed' is a bit vague. It would be clearer to state what needs to be done to enable mypy for this package. Consider rephrasing to clarify that a py.typed file is needed.
| # Enable mypy once this bug is fixed. | |
| # Enable mypy once this package has a py.typed file. |
| """Run the type checker.""" | ||
|
|
||
| # TODO(https://github.com/googleapis/google-cloud-python/issues/13362): | ||
| # Enable mypy once this bug is fixed. |
There was a problem hiding this comment.
The comment 'Enable mypy once this bug is fixed' is a bit vague. It would be clearer to state what needs to be done to enable mypy for this package. Consider rephrasing to clarify that a py.typed file is needed.
| # Enable mypy once this bug is fixed. | |
| # Enable mypy once this package has a py.typed file. |
See follow up issue #13362