Skip to content

tests: skip mypy for packages without py.typed #15565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 1 commit into from
Feb 12, 2026
Merged

tests: skip mypy for packages without py.typed #15565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/google-cloud-access-context-manager/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,15 @@ def format(session):
)


@nox.session(python=DEFAULT_PYTHON_VERSION)
def mypy(session):
"""Run the type checker."""

# TODO(https://github.com/googleapis/google-cloud-python/issues/13362):
# Enable mypy once this bug is fixed.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment 'Enable mypy once this bug is fixed' is a bit vague. It would be clearer to state what needs to be done to enable mypy for this package. Consider rephrasing to clarify that a py.typed file is needed.

Suggested change
# Enable mypy once this bug is fixed.
# Enable mypy once this package has a py.typed file.

session.skip("Skip mypy since this library doesn't have py.typed")


@nox.session(python=DEFAULT_PYTHON_VERSION)
def lint_setup_py(session):
"""Verify that setup.py is valid (including RST check)."""
Expand Down
9 changes: 9 additions & 0 deletions packages/google-cloud-audit-log/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,15 @@ def format(session):
)


@nox.session(python=DEFAULT_PYTHON_VERSION)
def mypy(session):
"""Run the type checker."""

# TODO(https://github.com/googleapis/google-cloud-python/issues/13362):
# Enable mypy once this bug is fixed.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment 'Enable mypy once this bug is fixed' is a bit vague. It would be clearer to state what needs to be done to enable mypy for this package. Consider rephrasing to clarify that a py.typed file is needed.

Suggested change
# Enable mypy once this bug is fixed.
# Enable mypy once this package has a py.typed file.

session.skip("Skip mypy since this library doesn't have py.typed")


@nox.session(python=DEFAULT_PYTHON_VERSION)
def lint_setup_py(session):
"""Verify that setup.py is valid (including RST check)."""
Expand Down
9 changes: 9 additions & 0 deletions packages/googleapis-common-protos/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,15 @@ def format(session):
)


@nox.session(python=DEFAULT_PYTHON_VERSION)
def mypy(session):
"""Run the type checker."""

# TODO(https://github.com/googleapis/google-cloud-python/issues/13362):
# Enable mypy once this bug is fixed.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment 'Enable mypy once this bug is fixed' is a bit vague. It would be clearer to state what needs to be done to enable mypy for this package. Consider rephrasing to clarify that a py.typed file is needed.

Suggested change
# Enable mypy once this bug is fixed.
# Enable mypy once this package has a py.typed file.

session.skip("Skip mypy since this library doesn't have py.typed")


@nox.session(python=DEFAULT_PYTHON_VERSION)
def lint_setup_py(session):
"""Verify that setup.py is valid (including RST check)."""
Expand Down
9 changes: 9 additions & 0 deletions packages/grpc-google-iam-v1/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,15 @@ def format(session):
)


@nox.session(python=DEFAULT_PYTHON_VERSION)
def mypy(session):
"""Run the type checker."""

# TODO(https://github.com/googleapis/google-cloud-python/issues/13362):
# Enable mypy once this bug is fixed.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment 'Enable mypy once this bug is fixed' is a bit vague. It would be clearer to state what needs to be done to enable mypy for this package. Consider rephrasing to clarify that a py.typed file is needed.

Suggested change
# Enable mypy once this bug is fixed.
# Enable mypy once this package has a py.typed file.

session.skip("Skip mypy since this library doesn't have py.typed")


@nox.session(python=DEFAULT_PYTHON_VERSION)
def lint_setup_py(session):
"""Verify that setup.py is valid (including RST check)."""
Expand Down
Loading