feat: Show all selected languages and categories in online library by harshsomankar123-tech · Pull Request #4705 · kiwix/kiwix-android

harshsomankar123-tech · 2026-02-19T10:55:34Z

Summary
Enabled multi-selection support for languages and categories in the online library, allowing users to filter content across multiple criteria simultaneously.

Key Changes
Filter Expansion: Updated the online library logic to process and display results for all selected languages and categories rather than a single selection.

UI/UX Updates:

implemented HeaderText composable for improved layout consistency.
Adjusted LanguageScreen.kt layout modifiers to correctly handle bottom bar padding.
Added resetSearchState functionality to clear filters and search text efficiently.

Test & CI Fixes:

Resolved failing testLanguageFragment and other UI test suites by restoring flow consumption bounds.
Added automated clearing of language and category filters during download test setup to prevent cross-test interference.
Static Analysis: Suppressed LongParameterList detekt warnings in ZimManageViewModel following the architectural changes.

Screenshots

Screen.Recording.2026-02-19.at.16.21.34.mov

MohitMaliFtechiz

@harshsomankar123-tech The testLanguageFragment is failing, please fix that one. Also see the review changes.

MohitMaliFtechiz · 2026-02-23T10:32:38Z

-import org.kiwix.kiwixmobile.core.utils.ComposeDimens
-
-@Composable
-fun HeaderText(


Do not remove this. We should show the selected languages in a section as it was showing previously. Don't change the UI. If you see in the current video you have uploaded in the PR description, it does not look good.

MohitMaliFtechiz · 2026-02-23T10:34:31Z

        .padding(ComposeDimens.SIXTEEN_DP)
        .semantics {
-          testTag = "$LANGUAGE_ITEM_RADIO_BUTTON_TESTING_TAG${language.language}"
+          testTag = "languageItemCheckboxTestingTag${language.language}"


Do not hardcode the tags. It should be used from the constant as it was before.

MohitMaliFtechiz · 2026-02-23T10:38:00Z

  var isSearchActive by rememberSaveable { mutableStateOf(false) }

  fun resetSearchState() {
-    // clears the search text and resets the filter


Do not remove the comments.

MohitMaliFtechiz · 2026-02-23T10:38:44Z

    Column(
      modifier = Modifier
        .fillMaxSize()
-        // setting bottom padding to zero to avoid accounting for Bottom bar


Here too. It helps us understand why we have added the code.

MohitMaliFtechiz · 2026-02-23T10:39:07Z

-      else -> null // Handle the case when both conditions are false
+      else -> null
    },
-    // Second item: always included


MohitMaliFtechiz · 2026-02-23T11:20:41Z

+import org.kiwix.kiwixmobile.core.ui.components.ONE
+
+object OnlineLibraryHeaderHelper {
+  fun getOnlineLibrarySectionTitle(


This method should be placed in the viewModel. It does not need to be written in a separate class.

MohitMaliFtechiz · 2026-02-23T11:28:54Z

+import org.kiwix.kiwixmobile.core.zim_manager.fileselect_view.BooksOnDiskListItem.BookOnDisk
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem
+
+sealed class FileSelectActions {


These should not be separate. Because now we are splitting things into dedicated viewModels. E.g., LibraryViewModel, OnlineViewModel, so these will be automatically split into those view models and reduce the size of the viewModel.

MohitMaliFtechiz · 2026-02-23T11:32:15Z

+  val kiwixService: KiwixService
+)
+
+object OnlineLibraryServiceFactory {


@harshsomankar123-tech I appreciate your thinking of splitting this one. But this should be a class, not an object, and it should be injected into the viewModel, then we should use it. It would be easy for testing as well.

MohitMaliFtechiz · 2026-02-23T11:38:52Z

-            originalResponse
-          }
+  private fun createBaseOkHttpClient(): OkHttpClient =
+    OkHttpClient().newBuilder()


We are creating this OkHttpClient here and updating this in OnlineLibraryServiceFactory, which is not a good idea. Because this OkHttpClient is only used for getting the online books, and it should be prepared in one place. So we should move this to OnlineLibraryServiceFactory.

We need the baseClient in getContentLengthOfLibraryXmlFile so it can be easily accessible from that class.

harshsomankar123-tech · 2026-02-26T21:07:04Z

@MohitMaliFtechiz I’ve pushed the latest updates. Please review when you get a chance. If the changes look fine, I’ll move ahead with resolving the CI failures.

MohitMaliFtechiz

@harshsomankar123-tech There are some issues and improvements. See the video below.

When we select the "All category" or "All language" and come back again to the category or language screen, they are not selected.
The second thing is if the user selects the "All category" then all other categories should be deselected. Or if the "All category" is selected and the user selects another category, then "All category" should be deselected. Because it does not make sense when a user wants to get books of a category, and also the "All category" is selected. Same for language as well.

screen-20260227-145906-1772184476548.mp4

The second thing is where we are selecting multiple languages. The text does not look good.
Also, there is no text to show which categories are selected. We should show that also as we are showing the languages.

MohitMaliFtechiz · 2026-02-27T09:48:51Z

 import javax.inject.Inject

-class LanguageViewModel @Inject constructor(
+open class LanguageViewModel @Inject constructor(


We should keep this as a final class. We should not make it open just for setting isUnitTestCase.

MohitMaliFtechiz · 2026-02-27T09:49:42Z

There is already a function for this.

MohitMaliFtechiz · 2026-02-27T09:53:35Z

+      is Filter -> filter(action, currentState)
+      is Select -> select(action, currentState)
+      Save -> saveAction(currentState)
+      ClearAll -> clearAll(currentState)


From where this ClearAll is emitting. I am not seeing any usage of it in the real codebase.

Same for SelectAll, and Cancel.

MohitMaliFtechiz · 2026-02-27T09:59:09Z

 import javax.inject.Inject

-class CategoryViewModel @Inject constructor(
+open class CategoryViewModel @Inject constructor(


Same for this class.

MohitMaliFtechiz · 2026-02-27T10:01:37Z

+      is Filter -> filter(action, currentState)
+      is Select -> select(action, currentState)
+      Action.Save -> saveAction(currentState)
+      Action.ClearAll -> clearAll(currentState)


Same for these ones? Cancel, SelectAll, and ClearAll.

MohitMaliFtechiz · 2026-02-27T10:03:46Z

          title = stringResource(R.string.select_category),
-          navigationIcon = navigationIcon
+          navigationIcon = navigationIcon,
+          actionMenuItems = listOf(


We should split this into a function to improve readability and future improvements.

MohitMaliFtechiz · 2026-02-27T10:04:14Z

        when (item) {
          is HeaderItem -> "header_${item.id}"
-          is CategoryItem -> "language_${item.category.id}"
+          is CategoryItem -> "category_${item.category.id}"


Good catch!!

MohitMaliFtechiz · 2026-02-27T10:11:52Z

+import org.kiwix.kiwixmobile.core.entity.LibkiwixBook
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem
+
+data class OnlineLibraryRequest(


For this ZimManageModels class. We will now move it to the OnlineLibraryViewModel so the name of this class should be more familiar with that. Also, ZimManageModels does not justify its class responsibility. Because it only contains the onlineLibrary models. So the class name should be improved here.

harshsomankar123-tech · 2026-03-15T23:30:44Z

@MohitMaliFtechiz PTAL

harshsomankar123-tech · 2026-04-08T10:02:21Z

@MohitMaliFtechiz PTAL When u have some time
Thanks!

codecov · 2026-04-08T11:49:09Z

Codecov Report

❌ Patch coverage is 60.47431% with 100 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.40%. Comparing base (59f114c) to head (0be9fb3).

Files with missing lines	Patch %	Lines
...kiwix/kiwixmobile/zimManager/ZimManageViewModel.kt	57.14%	25 Missing and 5 partials ⚠️
...tion/library/online/viewmodel/CategoryViewModel.kt	17.64%	21 Missing and 7 partials ⚠️
...iwixmobile/language/viewmodel/LanguageViewModel.kt	35.00%	20 Missing and 6 partials ⚠️
...ixmobile/zimManager/OnlineLibraryServiceFactory.kt	82.92%	3 Missing and 4 partials ⚠️
...iwix/kiwixmobile/zimManager/OnlineLibraryModels.kt	81.81%	4 Missing ⚠️
.../nav/destination/library/online/viewmodel/State.kt	77.77%	0 Missing and 2 partials ⚠️
...org/kiwix/kiwixmobile/language/viewmodel/Action.kt	0.00%	1 Missing ⚠️
.../org/kiwix/kiwixmobile/language/viewmodel/State.kt	88.88%	0 Missing and 1 partial ⚠️
...nav/destination/library/online/viewmodel/Action.kt	50.00%	1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (60.47%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #4705      +/-   ##
============================================
- Coverage     60.61%   60.40%   -0.21%     
- Complexity     1674     1679       +5     
============================================
  Files           333      335       +2     
  Lines         16020    16112      +92     
  Branches       2224     2237      +13     
============================================
+ Hits           9711     9733      +22     
- Misses         4834     4911      +77     
+ Partials       1475     1468       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…n bounds

…arge files

…language

harshsomankar123-tech marked this pull request as draft February 19, 2026 10:56

harshsomankar123-tech force-pushed the language branch 5 times, most recently from fbb5f14 to e91837d Compare February 21, 2026 15:59

harshsomankar123-tech marked this pull request as ready for review February 22, 2026 19:57

MohitMaliFtechiz self-requested a review February 23, 2026 10:32

MohitMaliFtechiz requested changes Feb 23, 2026

View reviewed changes

harshsomankar123-tech marked this pull request as draft February 23, 2026 13:58

harshsomankar123-tech added a commit to harshsomankar123-tech/kiwix-android that referenced this pull request Feb 25, 2026

fix: address PR kiwix#4705 review comments and fix CI test failures

8fbf279

harshsomankar123-tech added a commit to harshsomankar123-tech/kiwix-android that referenced this pull request Feb 25, 2026

fix: address PR kiwix#4705 review comments and fix CI test failures

e767072

harshsomankar123-tech force-pushed the language branch 2 times, most recently from 1eb04bf to 55e5046 Compare February 25, 2026 21:13

harshsomankar123-tech marked this pull request as ready for review February 26, 2026 19:14

MohitMaliFtechiz self-requested a review February 27, 2026 07:08

MohitMaliFtechiz requested changes Feb 27, 2026

View reviewed changes

harshsomankar123-tech marked this pull request as draft February 27, 2026 10:20

harshsomankar123-tech added a commit to harshsomankar123-tech/kiwix-android that referenced this pull request Mar 1, 2026

fix: address PR kiwix#4705 review comments and fix CI test failures

3952e8d

harshsomankar123-tech force-pushed the language branch 2 times, most recently from 9ddc7bf to b8750fc Compare March 2, 2026 22:52

harshsomankar123-tech marked this pull request as ready for review March 3, 2026 06:24

harshsomankar123-tech marked this pull request as draft March 6, 2026 16:57

harshsomankar123-tech force-pushed the language branch 2 times, most recently from 694e7c5 to f8f1c71 Compare March 6, 2026 17:35

harshsomankar123-tech added a commit to harshsomankar123-tech/kiwix-android that referenced this pull request Mar 15, 2026

fix: address PR kiwix#4705 review comments and fix CI test failures

3067ea0

harshsomankar123-tech force-pushed the language branch from f8f1c71 to 6fc36f1 Compare March 15, 2026 22:03

harshsomankar123-tech marked this pull request as ready for review March 15, 2026 23:30

MohitMaliFtechiz self-requested a review March 16, 2026 12:53

harshsomankar123-tech added a commit to harshsomankar123-tech/kiwix-android that referenced this pull request Mar 16, 2026

fix: address PR kiwix#4705 review comments and fix CI test failures

8c210da

harshsomankar123-tech force-pushed the language branch from ecfd8b6 to 861c2bd Compare March 16, 2026 17:14

harshsomankar123-tech marked this pull request as draft March 18, 2026 18:37

harshsomankar123-tech added a commit to harshsomankar123-tech/kiwix-android that referenced this pull request Mar 22, 2026

fix: address PR kiwix#4705 review comments and fix CI test failures

f89a23e

harshsomankar123-tech force-pushed the language branch from 0bd4be3 to 3c44629 Compare March 22, 2026 01:58

harshsomankar123-tech added a commit to harshsomankar123-tech/kiwix-android that referenced this pull request Mar 25, 2026

fix: address PR kiwix#4705 review comments and fix CI test failures

f5dd4cd

harshsomankar123-tech force-pushed the language branch from 3c44629 to 61ad15b Compare March 25, 2026 11:05

harshsomankar123-tech added a commit to harshsomankar123-tech/kiwix-android that referenced this pull request Mar 25, 2026

fix: address PR kiwix#4705 review comments and fix CI test failures

fc35f32

harshsomankar123-tech force-pushed the language branch from 61ad15b to f71fd75 Compare March 25, 2026 11:14

harshsomankar123-tech added a commit to harshsomankar123-tech/kiwix-android that referenced this pull request Apr 7, 2026

fix: address PR kiwix#4705 review comments and fix CI test failures

69d208e

harshsomankar123-tech force-pushed the language branch from edf3792 to a9c1927 Compare April 7, 2026 12:30

harshsomankar123-tech added a commit to harshsomankar123-tech/kiwix-android that referenced this pull request Apr 8, 2026

fix: address PR kiwix#4705 review comments and fix CI test failures

0a9662c

harshsomankar123-tech force-pushed the language branch from a9c1927 to f58ad83 Compare April 8, 2026 10:00

harshsomankar123-tech marked this pull request as ready for review April 8, 2026 10:01

harshsomankar123-tech added 11 commits April 15, 2026 22:21

feat: Show all selected languages and categories in online library

211e494

fix(tests): resolve failing suites by restoring exact flow consumptio…

b206dd1

…n bounds

fix: address PR kiwix#4705 review comments and fix CI test failures

45f2a83

fix: suppress LongParameterList detekt warning in ZimManageViewModel

771f0b4

fix(test): resolve CI UI test failures

e100dcf

fix: clear language/category filters in download test setup

d42c5ea

fix: address review comments for language and category

e6b681e

Fix build, Dagger, Detekt, and formatting errors

420b12e

fix(test): revert to searchD3JsDocsFile to prevent CI timeouts with l…

363df3b

…arge files

fix: resolve CI compilation errors and use testTag constants

295968b

fix: resolve CI failure in LanguageViewModelTest by mocking selected …

0be9fb3

…language

harshsomankar123-tech force-pushed the language branch from f58ad83 to 0be9fb3 Compare April 15, 2026 16:55

Uh oh!

Conversation

harshsomankar123-tech commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MohitMaliFtechiz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harshsomankar123-tech commented Feb 26, 2026

Uh oh!

MohitMaliFtechiz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harshsomankar123-tech commented Mar 15, 2026

Uh oh!

harshsomankar123-tech commented Apr 8, 2026

Uh oh!

codecov bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

harshsomankar123-tech commented Feb 19, 2026 •

edited

Loading

codecov bot commented Apr 8, 2026 •

edited

Loading