Skip to content

fix: Improve Docker availability check using exit code and error match#378

Merged
Prajwal-Microsoft merged 1 commit intomainfrom
PSL-BUG-17679
May 5, 2025
Merged

fix: Improve Docker availability check using exit code and error match#378
Prajwal-Microsoft merged 1 commit intomainfrom
PSL-BUG-17679

Conversation

@Prasanjeet-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

  • Enhance the robustness of the Docker status check logic. The previous implementation relied solely on matching the exact error message "ERROR: error during connect", which was unreliable and could miss actual failures. This update improves reliability by also checking $LASTEXITCODE and matching a broader substring "error during connect" to ensure Docker is properly validated before proceeding with deploymen.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid:

  • Stop Docker Desktop and run the script — it should correctly detect that Docker is not running.
  • Start Docker Desktop and run again — the check should pass without errors.
  • Ensure the deployment is prevented if Docker is not running.

@Prajwal-Microsoft Prajwal-Microsoft merged commit 8dd68df into main May 5, 2025
5 checks passed
@Prasanjeet-Microsoft Prasanjeet-Microsoft deleted the PSL-BUG-17679 branch May 29, 2025 18:21
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants