fix: Handling Private network connections with existing foundry projrect#242
Merged
Prajwal-Microsoft merged 20 commits intodevfrom Aug 5, 2025
Merged
fix: Handling Private network connections with existing foundry projrect#242Prajwal-Microsoft merged 20 commits intodevfrom
Prajwal-Microsoft merged 20 commits intodevfrom
Conversation
…to-bicep fix: updated model capacity to minimum 100
…_doc docs: Added Documentation for Reusing Azure AI Foundry Project
…dard chore: migrate model type to global standard
fix: add principalType as 'ServicePrincipal' for role assignments
fix: Resolve Deployment Lifecycle Automation pipeline failure
fix: Prefix/Suffix fixes & package upgrades - dev to main
feat: Use ManagedIdentityCredential fir Prod Workloads and DefaultAzureCredential for dev
Prajwal-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Prajwal-Microsoft
changed the title
Prajwal-Microsoft
added a commit
that referenced
this pull request
Aug 7, 2025
* feat: Down merge from main to dev (#240) * updated model capacity to minimum 100 * Add principalType 'ServicePrincipal' to role assignments in Bicep modules * update mainjson file * removed text embedding condition * add reuse guide for existing Azure AI Foundry project * remove redundant replica settings for container and API apps in deployment workflow * disable private networking in deployment parameters * normalize secondary location value to lowercase in deployment parameters * fix: correct casing for SOLUTION_NAME in deployment output extraction * refactor: remove unused SOLUTION_NAME output and related steps in deployment workflow * fix: prepend https to CONTAINER_WEB_APPURL in deployment output extraction --------- Co-authored-by: Priyanka-Microsoft <v-prisinghal@microsoft.com> Co-authored-by: Roopan-Microsoft <168007406+Roopan-Microsoft@users.noreply.github.com> Co-authored-by: Abdul-Microsoft <v-amujeebta@microsoft.com> Co-authored-by: Prasanjeet-Microsoft <v-singhprasa@microsoft.com> Co-authored-by: Vinay Sharma <v-vinayshar@microsoft.com> * feat: Down merge from main to dev (#241) * updated model capacity to minimum 100 * Add principalType 'ServicePrincipal' to role assignments in Bicep modules * update mainjson file * removed text embedding condition * add reuse guide for existing Azure AI Foundry project * remove redundant replica settings for container and API apps in deployment workflow * disable private networking in deployment parameters * normalize secondary location value to lowercase in deployment parameters * fix: correct casing for SOLUTION_NAME in deployment output extraction * refactor: remove unused SOLUTION_NAME output and related steps in deployment workflow * fix: prepend https to CONTAINER_WEB_APPURL in deployment output extraction --------- Co-authored-by: Priyanka-Microsoft <v-prisinghal@microsoft.com> Co-authored-by: Roopan-Microsoft <168007406+Roopan-Microsoft@users.noreply.github.com> Co-authored-by: Abdul-Microsoft <v-amujeebta@microsoft.com> Co-authored-by: Prasanjeet-Microsoft <v-singhprasa@microsoft.com> Co-authored-by: Vinay Sharma <v-vinayshar@microsoft.com> * fix: Handling Private network connections with existing foundry projrect (#242) * updated model capacity to minimum 100 * Add principalType 'ServicePrincipal' to role assignments in Bicep modules * update mainjson file * removed text embedding condition * add reuse guide for existing Azure AI Foundry project * remove redundant replica settings for container and API apps in deployment workflow * disable private networking in deployment parameters * normalize secondary location value to lowercase in deployment parameters * fix: correct casing for SOLUTION_NAME in deployment output extraction * refactor: remove unused SOLUTION_NAME output and related steps in deployment workflow * fix: prepend https to CONTAINER_WEB_APPURL in deployment output extraction * fix: Disable Network configurations in case of resuing the foundry project --------- Co-authored-by: Priyanka-Microsoft <v-prisinghal@microsoft.com> Co-authored-by: Roopan-Microsoft <168007406+Roopan-Microsoft@users.noreply.github.com> Co-authored-by: Abdul-Microsoft <v-amujeebta@microsoft.com> Co-authored-by: Prasanjeet-Microsoft <v-singhprasa@microsoft.com> Co-authored-by: Vinay Sharma <v-vinayshar@microsoft.com> * fix: Resolved conflicts --------- Co-authored-by: Priyanka-Microsoft <v-prisinghal@microsoft.com> Co-authored-by: Roopan-Microsoft <168007406+Roopan-Microsoft@users.noreply.github.com> Co-authored-by: Abdul-Microsoft <v-amujeebta@microsoft.com> Co-authored-by: Prasanjeet-Microsoft <v-singhprasa@microsoft.com> Co-authored-by: Vinay Sharma <v-vinayshar@microsoft.com>
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the infrastructure Bicep and generated ARM template files to improve resource ID handling, streamline diagnostic settings references, and ensure private endpoints are only created when needed. It also updates the Bicep compiler version and template hashes throughout the generated files.
Key changes include:
Resource ID handling and parameter cleanup:
existingProjectResourceIdvariable and used it throughout the Bicep and ARM templates to ensure consistent and clean handling of existing resource IDs. This variable is now passed to modules and used in resource conditions.Private endpoint logic improvements:
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information