Skip to content

fix: Handling Private network connections with existing foundry projrect #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prajwal-Microsoft merged 20 commits into from
Aug 5, 2025
Merged

fix: Handling Private network connections with existing foundry projrect #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4cf3d45
updated model capacity to minimum 100
Priyanka-Microsoft Jul 14, 2025
2d12c28
Merge pull request #220 from microsoft/update-model-capacity-similar-…
Roopan-Microsoft Jul 14, 2025
aed550f
Add principalType 'ServicePrincipal' to role assignments in Bicep mod…
Abdul-Microsoft Jul 18, 2025
bb6780e
update mainjson file
Abdul-Microsoft Jul 18, 2025
10c5d13
removed text embedding condition
Priyanka-Microsoft Jul 18, 2025
7b18b47
add reuse guide for existing Azure AI Foundry project
Prasanjeet-Microsoft Jul 18, 2025
0f40bd9
Merge pull request #226 from microsoft/psl_add_resuse_foundry_project…
Prajwal-Microsoft Jul 18, 2025
88bafa6
remove redundant replica settings for container and API apps in deplo…
Abdul-Microsoft Jul 21, 2025
bb1f323
disable private networking in deployment parameters
Abdul-Microsoft Jul 21, 2025
cb1131d
normalize secondary location value to lowercase in deployment parameters
Abdul-Microsoft Jul 21, 2025
3ec1a56
fix: correct casing for SOLUTION_NAME in deployment output extraction
Abdul-Microsoft Jul 22, 2025
62bae10
Merge pull request #223 from microsoft/update-modeltype-to-globalstan…
Roopan-Microsoft Jul 22, 2025
279aced
Merge pull request #224 from microsoft/psl-fixPrincipalTypeIssue
Prajwal-Microsoft Jul 22, 2025
928c914
refactor: remove unused SOLUTION_NAME output and related steps in dep…
Abdul-Microsoft Jul 23, 2025
29586d3
fix: prepend https to CONTAINER_WEB_APPURL in deployment output extra…
Abdul-Microsoft Jul 23, 2025
8b76892
Merge pull request #230 from microsoft/psl-deploypipelinefix
Abdul-Microsoft Jul 23, 2025
2643dcc
Merge pull request #233 from microsoft/dev
Prajwal-Microsoft Jul 24, 2025
86a1962
Merge pull request #236 from microsoft/dev
Vinay-Microsoft Jul 31, 2025
295450c
fix: Disable Network configurations in case of resuing the foundry pr…
Prajwal-Microsoft Aug 1, 2025
2891129
Merge remote-tracking branch 'origin/dev' into network-bug-fix
Prajwal-Microsoft Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ var solutionPrefix = 'cps-${padLeft(take(toLower(uniqueString(subscription().id,
// Resources //
// ============== //

var existingProjectResourceId = trim(existingFoundryProjectResourceId)

// ========== AVM Telemetry ========== //
#disable-next-line no-deployments-resources
resource avmTelemetry 'Microsoft.Resources/deployments@2024-03-01' = if (enableTelemetry) {
Expand Down Expand Up @@ -579,7 +581,7 @@ module avmAiServices 'modules/account/main.bicep' = {
name: 'aisa-${solutionPrefix}'
projectName: 'aifp-${solutionPrefix}'
projectDescription: 'aifp-${solutionPrefix}'
existingFoundryProjectResourceId: existingFoundryProjectResourceId
existingFoundryProjectResourceId: existingProjectResourceId
location: aiDeploymentsLocation
sku: 'S0'
allowProjectManagement: true
Expand Down Expand Up @@ -632,7 +634,7 @@ module avmAiServices 'modules/account/main.bicep' = {
// WAF related parameters
publicNetworkAccess: (enablePrivateNetworking) ? 'Disabled' : 'Enabled'
//publicNetworkAccess: 'Enabled' // Always enabled for AI Services
privateEndpoints: (enablePrivateNetworking)
privateEndpoints: (enablePrivateNetworking && empty(existingProjectResourceId))
? [
{
name: 'ai-services-private-endpoint-${solutionPrefix}'
Expand Down
Loading
Loading