Refactor: remove unused input state handling in CopilotCLIChatSessionContentProvider#309945
Merged
DonJayamanne merged 1 commit intomainfrom Apr 14, 2026
Merged
Refactor: remove unused input state handling in CopilotCLIChatSessionContentProvider#309945DonJayamanne merged 1 commit intomainfrom
DonJayamanne merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR removes newly-created-session input state caching and related workaround logic in CopilotCLIChatSessionContentProvider to simplify chat session management.
Changes:
- Removed
ResourceMap<WeakRef<ChatSessionInputState>>caching for new sessions. - Removed precomputing/storing option groups in
newChatSessionItemHandler. - Simplified
getChatSessionInputStateto rely oncontext.previousInputState.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessions.ts | Removes new-session input state caching/workaround and uses context.previousInputState directly when building option groups. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessions.ts
Show resolved
Hide resolved
extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessions.ts
Show resolved
Hide resolved
Yoyokrazy
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate unnecessary input state handling in the CopilotCLIChatSessionContentProvider to streamline the code and improve maintainability. This change simplifies the session management logic by removing redundant state management. Testing can be done by verifying that chat sessions function correctly without the removed input state handling.